Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge changes made up for now (HotoRas#3) #5

Merged
merged 11 commits into from
Jun 9, 2024
Merged

Merge changes made up for now (HotoRas#3) #5

merged 11 commits into from
Jun 9, 2024

Conversation

HotoRas
Copy link

@HotoRas HotoRas commented Jun 5, 2024

변경점

  • 적절하게 처리된 업스트림 풀링
    • 브랜치 io에 있던 고양이별용 변경사항 끌어오기 포함
    • 현재 브랜치 host의 프론트엔드가 적절하게 렌더링되지 않는 문제를 해결합니다 (heavily tested on Docker)
  • 기존에 언급했던, 프론트엔드 타입핑
    • Vite 파일을 제외한 모든 파일에서, RAM이 부족해 따라가지 못한 것을 제외한 모든 타입 지정 완료: 진행률 약 30%

추가사항

@HotoRas HotoRas changed the title Fix frontend not being displayed (HotoRas#3) Merge changes made up for now (HotoRas#3) Jun 8, 2024
@HotoRas HotoRas marked this pull request as ready for review June 8, 2024 03:26
@seojangho seojangho self-requested a review June 8, 2024 15:36
laonmofu
laonmofu approved these changes Jun 8, 2024
View reviewed changes
Copy link
Collaborator

@laonmofu laonmofu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!
3

seojangho
seojangho approved these changes Jun 8, 2024
View reviewed changes
Copy link

@seojangho seojangho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다.

@HotoRas
Copy link
Author

HotoRas commented Jun 9, 2024

병합 진행하겠습니다!

@HotoRas HotoRas merged commit e8a9b16 into nekoplanet:host Jun 9, 2024
@HotoRas HotoRas deleted the nekopatch/update/2024.5.0-host.1 branch June 22, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seojangho seojangho seojangho approved these changes

@laonmofu laonmofu laonmofu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HotoRas @seojangho @laonmofu