AiderTest command #14
Conversation
WalkthroughThe changes in this pull request enhance the command registration process in the Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
| @@ -97,12 +109,12 @@ export async function main(denops: Denops): Promise<void> { | |||
| await command("addWeb", "1", async (url: string) => { | |||
| const prompt = `/web ${url}`; | |||
| await v.r.set(denops, "q", prompt); | |||
| await denops.dispatcher.sendPromptWithInput(url); | |||
| await denops.dispatcher.sendPromptWithInput(); | |||
There was a problem hiding this comment.
denops渡すべきっぽいところにurlとかquestionとか渡していて壊してたかと思いきや動いていて、
mainのsendPromptWithImputは引数を取らないので無視されていたっぽい
| }, | ||
| "[<f-args>]", | ||
| false, | ||
| "shellcmd", |
There was a problem hiding this comment.
optionalな引数がだいぶ増えてしまったので1つのopts的なオブジェクト引数にまとめるやつを次やるとおもわれます
| @@ -97,12 +109,12 @@ export async function main(denops: Denops): Promise<void> { | |||
| await command("addWeb", "1", async (url: string) => { | |||
| const prompt = `/web ${url}`; | |||
| await v.r.set(denops, "q", prompt); | |||
There was a problem hiding this comment.
v.r.setしてからsendPromptWithImputするのはコード上に出ない状態ができてしまってつらいのでbuffer.sendPromptWithInput(denops, input) みたいにinputも渡して中でv.r.setする方がよさそう
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- denops/aider/main.ts (5 hunks)
🔇 Additional comments (6)
denops/aider/main.ts (6)
16-18: Type definition for 'CompleteType' is well-definedThe
CompleteTypegeneric type correctly mapsArgCountto the appropriate completion options, enhancing type safety and improving command completion functionality.
40-40: Addition of 'complete' parameter enhances command flexibilityIntroducing the
completeparameter to thecommandfunction allows specifying completion types, which improves user experience by providing appropriate command-line completions.
46-46: Correct construction of 'completePart' for command definitionThe
completePartvariable is properly constructed to include the-completeoption when a completion type is specified, ensuring commands have the correct completion behavior.
48-48: Command registration string correctly incorporates completion optionsThe command definition now includes
completePart,rangePart, and other parameters, ensuring that commands are registered with the correct options and behaviors.
92-103: 'addFile' command enhanced with file path completionThe
addFilecommand now specifiescompleteas"file", enabling filename completion when users invoke the command. This enhances usability by allowing users to easily select file paths.
145-156: Review security implications of 'test' command accepting shell commandsThe new
testcommand usescompleteas"shellcmd", allowing shell command completion. Since it accepts user input and incorporates it into a prompt (/test ${cmd}), ensure that this input is handled safely downstream to prevent potential security vulnerabilities like command injection.Run the following script to verify how
/testprompts are processed and ensure user input is safely handled:✅ Verification successful
Verified: 'test' command safely handles user input
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Search the codebase for handling of '/test' prompts. # Test: Ensure that '/test' commands are processed safely. rg --type typescript '/test' -A 5 -B 5Length of output: 73
Script:
#!/bin/bash # Description: Search the codebase for handling of '/test' prompts in TypeScript files. # Test: Ensure that '/test' commands are processed safely. rg '/test' --include '\.ts$' --include '\.tsx$' -A 5 -B 5Length of output: 499
Script:
#!/bin/bash # Description: Search the codebase for handling of '/test' prompts in TypeScript files. # Test: Ensure that '/test' commands are processed safely. rg '/test' -g '*.ts' -g '*.tsx' -A 5 -B 5Length of output: 1344
Script:
#!/bin/bash # Description: Trace the handling of user input for the '/test' command to ensure safe processing. # Search for all instances where 'sendPromptWithInput' is called to understand how user input is handled. rg 'sendPromptWithInput' -g '*.ts' -A 10 -B 10 # Additionally, search for any shell command executions that might use the 'prompt' or 'cmd' variables. rg 'exec|spawn|shell' -g '*.ts' -A 5 -B 5Length of output: 7207
| @@ -12,7 +12,10 @@ export async function main(denops: Denops): Promise<void> { | |||
| type ArgCount = "0" | "1" | "*"; | |||
| type ImplType<T extends ArgCount> = T extends "0" ? (() => Promise<void>) | |||
| : T extends "1" ? ((arg: string) => Promise<void>) | |||
| : ((arg: string, arg2: string) => Promise<void>); // MEMO: 1つめの引数、2つめの引数という意味 | |||
| : ((arg: string, arg2: string) => Promise<void>); // MEMO: ArgCountは*だが現状2つのみ対応している | |||
There was a problem hiding this comment.
🛠️ Refactor suggestion
Translate inline comment to English for consistency
The inline comment is in Japanese: // MEMO: ArgCountは*だが現状2つのみ対応している. To maintain consistency and readability for all contributors, please translate code comments to English.
denops/aider/main.ts
Outdated
| @@ -12,7 +12,10 @@ export async function main(denops: Denops): Promise<void> { | |||
| type ArgCount = "0" | "1" | "*"; | |||
| type ImplType<T extends ArgCount> = T extends "0" ? (() => Promise<void>) | |||
| : T extends "1" ? ((arg: string) => Promise<void>) | |||
| : ((arg: string, arg2: string) => Promise<void>); // MEMO: 1つめの引数、2つめの引数という意味 | |||
| : ((arg: string, arg2: string) => Promise<void>); // MEMO: 1つめの引数、2つめの引数という意味 ArgCountは*だが現状2つのみ対応している | |||
| }, | ||
| "[<f-args>]", | ||
| false, | ||
| "shellcmd", |
|
@tsukimizake |
/testが便利そうだったので追加したり、commandにcompleteが欲しかったのでtestとついでにaddfileに設定したりしましたSummary by CodeRabbit
New Features
testfor setting prompts with completion options.Bug Fixes
sendPromptWithInputmethod.