Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove gotest.tools #688

Merged
merged 2 commits into from
May 18, 2021
Merged

Conversation

catthehacker
Copy link
Member

  • remove all references to gotest.tools and replace it with
    github.com/stretchr/testify which was originally used for tests
  • bump golangci-lint version
  • add depguard and importas to prevent import of unwanted packages
  • add custom schema and information about config since
    schemastore.org has broken schema for golangci-lint config

hackercat added 2 commits May 12, 2021 12:17
* remove all references to `gotest.tools` and replace it with
  `github.com/stretchr/testify` which was originally used for tests
* bump `golangci-lint` version
* add `depguard` and `importas` to prevent import of unwanted packages
* add custom schema and information about config since
  schemastore.org has broken schema for `golangci-lint` config
@catthehacker catthehacker requested a review from a team as a code owner May 17, 2021 22:48
@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

Merging #688 (87c1dc1) into master (0f04942) will increase coverage by 1.24%.
The diff coverage is 60.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #688      +/-   ##
==========================================
+ Coverage   49.27%   50.51%   +1.24%     
==========================================
  Files          23       23              
  Lines        2401     2532     +131     
==========================================
+ Hits         1183     1279      +96     
- Misses       1090     1114      +24     
- Partials      128      139      +11     
Impacted Files Coverage Δ
pkg/container/docker_run.go 1.82% <0.00%> (-0.11%) ⬇️
pkg/model/workflow.go 30.71% <33.33%> (+5.00%) ⬆️
pkg/common/git.go 55.12% <33.92%> (-4.68%) ⬇️
pkg/model/planner.go 34.56% <41.37%> (+1.48%) ⬆️
pkg/container/docker_pull.go 36.17% <64.70%> (+17.98%) ⬆️
pkg/runner/step_context.go 71.99% <71.31%> (+3.04%) ⬆️
pkg/runner/run_context.go 79.74% <98.18%> (+3.33%) ⬆️
pkg/runner/runner.go 76.92% <100.00%> (+0.45%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa68181...87c1dc1. Read the comment docs.

@cplee cplee merged commit f571290 into nektos:master May 18, 2021
@mergify
Copy link
Contributor

mergify bot commented May 18, 2021

@catthehacker this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label May 18, 2021
@catthehacker catthehacker deleted the cat/refactor/testing branch September 27, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-work Extra attention is needed size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants