-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to interface{}
instead of map[string]...
#700
Conversation
Codecov Report
@@ Coverage Diff @@
## master #700 +/- ##
==========================================
+ Coverage 49.27% 49.88% +0.61%
==========================================
Files 23 23
Lines 2401 2568 +167
==========================================
+ Hits 1183 1281 +98
- Misses 1090 1146 +56
- Partials 128 141 +13
Continue to review full report at Codecov.
|
I'm actually surprised this works |
allows to use GitHub functions like `fromJson()`
This allows to use GitHub functions like `fromJson()` to create dynamic matrixes
3ff770c
to
62c23ea
Compare
interface{}
instead of map[string]...
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Checked |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ah right that may be some old act version, let me double chck sorry, I though go install will override other install, but maybe it didnt |
It should, but maybe it sometimes doesn't do that. I've been using |
I installed it properly, master version works fine, no yaml error. Thanks for this useful tool! |
currently getting unmarshal errors while running act for the first time in my repo:
is this a me problem or something not addressed in this fix? Im using v0.2.22 |
@sarah-liang this fix is not included in |
This comment has been minimized.
This comment has been minimized.
@aurimasniekis please create new issue |
Fixes issue with
env:
keys not being able to accept GitHub functions likefromJSON()
Fixes issue with matrixes not being able to be built with GitHub functions like
fromJSON()
Fixed issues:
fixes #284
fixes #540
fixes #450
fixes #330