fix msvc support for UTF_CPP_CPLUSPLUS #125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GoodenoughPhysicsLab
changed the title
GoodenoughPhysicsLab
force-pushed
the
master
branch
from
f95fc05
to
ec553b9
Compare
|
The goal is to avoid any compiler-specific code, including version macros. It is easy enough to define UTF_CPP_CPLUSPLUS if a compiler does not set __cplusplus correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yeah, in msvc, __cplusplus == 199711L, but we can use _MSVC_LANG for the same behavior. I give this patch because msvc is a popular compiler as gcc, clang.