This repository has been archived by the owner on Oct 31, 2020. It is now read-only.
Fix for occasional crash due to data updating #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -42,11 +42,11 @@ def add_data(self, id, time, data): | |||
| try: | |||
| if len(self.data) > 0 and self.data[0][1] > time: | |||
| del self.data[:] | |||
| except IndexError: | |||
There was a problem hiding this comment.
Would a better solution be to put some kind of semaphore around the data access bits?
There was a problem hiding this comment.
That would be a better solution, but I think it would be pretty complicated to get working (with the mix of java, python, servers, etc.). And since it doesn't really matter if we drop one packet every once in a while (this error is quite rare), I think the slacker solution is OK.
tbekolay
force-pushed
the
master
branch
2 times, most recently
from
2805c3d
to
bd8121c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Javaviz will randomly crash every once in a while, if data happens to get updated during this function. I just followed the previous solution of ignoring the error, since we'll be getting plenty more data.