sim_ocl can now handle updating matrices #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, sim_ocl would produce incorrect answers if the Y signal of a MultiProdUpdate operation were a matrix, rather than a 1D vector. Fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wow, I didn't realize that you had done this @e2crawfo! I did things the other way and revised Nengo's learning so that it doesn't need matrix-matrix multiplication.
I think this PR might still be a good thing to add, because it might help down the road to be able to do matrix-matrix multiplication. The one thing I'm not sure of is if we want to add this to the gemv kernel, like you did, or if we would want a specific matrix-matrix multiplication kernel.
I'm going to leave this unmerged for the time being, but I wanted to make a PR so that myself and others remember it's here, if we want to use it in the future.