-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests for gdal 3.4 and 3.6 #352
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
margrietpalm
force-pushed
the
margriet_257_fix_gdal_3.4
branch
from
February 15, 2024 09:34
e477f86
to
68edeaf
Compare
margrietpalm
force-pushed
the
margriet_257_fix_gdal_3.4
branch
from
February 15, 2024 13:15
379db49
to
257e6cd
Compare
margrietpalm
changed the title
fix tests for gdal 3.4 and 3.6
WIP: fix tests for gdal 3.4 and 3.6
Feb 16, 2024
…id-builder into margriet_257_fix_gdal_3.4
…ndle gdal 3.4 and newer
margrietpalm
changed the title
WIP: fix tests for gdal 3.4 and 3.6
fix tests for gdal 3.4 and 3.6
Feb 20, 2024
margrietpalm
changed the title
fix tests for gdal 3.4 and 3.6
WIP: fix tests for gdal 3.4 and 3.6
Feb 20, 2024
margrietpalm
force-pushed
the
margriet_257_fix_gdal_3.4
branch
from
February 21, 2024 11:06
fb28fea
to
4e7b3ea
Compare
margrietpalm
changed the title
WIP: fix tests for gdal 3.4 and 3.6
Fix tests for gdal 3.4 and 3.6
Feb 21, 2024
margrietpalm
requested review from
daanvaningen
and removed request for
martijn-siemerink
February 22, 2024 09:00
This reverts commit c2efb23.
daanvaningen
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎖️
…id-builder into margriet_257_fix_gdal_3.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix gdal 3.6 issues
test_rasterize_poly_refinement
andtest_rasterize_multiple_refinements
to fixtures and return based on gdal versionCases where the area to refine exactly matches the computational grid may have different refinements in gdal 3.4 then in gdal 3.6. Users should be informed about this on release
Fix gdal 3.4 issues
Allow failing (skipped) test
./threedigrid_builder/tests/test_raster_interfaces.py::test_crs
to pass by splitting the tests and running one orthe other based on the gdal version. This however does not ensure that there are no downstream effects.
Given
There is one call that gives a different result:
This call is used the property
RasterIORasterInterface.epsg_code
, which is subsequently used byRasterHasMatchingEPSGCheck.is_valid
where it could potentially change the result. This function seemed to be well tested, so any issues here should be caught.Furthermore, returning the actual spsg instead of
None
seems an improvement.Partially updated github action matrix