add example nep11 #1009

vikkkko · 2024-03-29T06:29:08Z

No description provided.

vncoelho

Perfect, can you verify the example https://github.com/neo-project/neo-devpack-dotnet/tree/master/examples/Example.SmartContract.NFT and maybe modify it as well?

I think there can be two examples there. Maybe give another name to each of them and move to the same folder.

Otherwise we can merge this example and do this merge later as well.

Jim8y · 2024-03-29T15:35:24Z

@vikkkko nice work, may you please use dotnet format to update the format?

cschuchardt88

Make changes and You need to write tests in order to approve this.

examples/Example.SmartContract.NEP11/Example.SmartContract.NEP11.csproj

examples/Example.SmartContract.NEP11/SampleNep11Token.cs

cschuchardt88 · 2024-03-30T14:15:58Z

Change project name to non-divisible NEP11.

…11.csproj Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>

vikkkko · 2024-04-01T03:31:36Z

Make changes and You need to write tests in order to approve this.

Some tests will be added later.

shargon · 2024-04-02T07:32:42Z

examples/Example.SmartContract.NonDivisibleNEP11/SampleNonDivisibleNEP11.cs

+        public static bool Update(ByteString nefFile, string manifest)
+        {
+            if (IsOwner() == false)
+                throw new InvalidOperationException("No Authorization!");


I prefer Asserts because are not cacheable.

shargon · 2024-04-02T07:33:12Z

examples/Example.SmartContract.NonDivisibleNEP11/SampleNonDivisibleNEP11.cs

+                throw new InvalidOperationException("No Authorization!");
+            for (uint i = 0; i < royaltyInfos.Length; i++)
+            {
+                if (((UInt160)royaltyInfos[i]["royaltyRecipient"]).IsValid == false ||


check existence?

check existence?

How? Maybe just a new address.

Royalties are not part of the NEP-11 standard. Isn't this going to confuse people?

I think we should either add a comment to the contract code that it (additionally) implements neo-project/proposals#155 or we should create one more separate example that includes Royalty standard implementation (and remove this royalty-related code from this contract).

shargon · 2024-04-02T07:33:33Z

examples/Example.SmartContract.NonDivisibleNEP11/SampleNonDivisibleNEP11.cs

+                    )
+                    throw new InvalidOperationException("Parameter error");
+            }
+            Storage.Put(PrefixRoyalty + tokenId, StdLib.Serialize(royaltyInfos));


Check tokenId format

shargon · 2024-04-02T07:33:51Z

examples/Example.SmartContract.NonDivisibleNEP11/SampleNonDivisibleNEP11.cs

+        [Safe]
+        public static bool Verify() => IsOwner();
+
+        public static bool Update(ByteString nefFile, string manifest)


Add data and send it to Update method

Just a side note: The ContractManagement will use byte[] and not string in the manifest parameter. I can see many examples using it this way. I'm not sure why, maybe it's because of Neo Express, but I can't be sure.

shargon · 2024-04-02T07:35:01Z

examples/Example.SmartContract.NonDivisibleNEP11/SampleNonDivisibleNEP11.cs

+        {
+            if (IsOwner() == false)
+                throw new InvalidOperationException("No Authorization!");
+            if (newOwner != null && newOwner.IsValid)


Suggested change

if (newOwner != null && newOwner.IsValid)

if (newOwner != null && newOwner.IsValid && !newOwner.IsZero)

Royalty example

examples/Example.SmartContract.NonDivisibleNEP11/SampleNonDivisibleNEP11.cs

…sibleNEP11.cs

examples/Example.SmartContract.NonDivisibleNEP11/SampleNonDivisibleNEP11.cs

…sibleNEP11.cs

examples/Example.SmartContract.NonDivisibleNEP11/SampleNonDivisibleNEP11.cs

…sibleNEP11.cs

examples/Example.SmartContract.NonDivisibleNEP11/SampleNonDivisibleNEP11.cs

…sibleNEP11.cs

examples/Example.SmartContract.NonDivisibleNEP11/SampleNonDivisibleNEP11.cs

…sibleNEP11.cs

Jim8y · 2024-04-03T15:31:45Z

examples/Example.SmartContract.NonDivisibleNEP11/SampleNonDivisibleNEP11.cs

+{
+    /// <inheritdoc />
+    [DisplayName("SampleNonDivisibleNEP11Token")]
+    [ContractAuthor("core-dev", "dev@neo.org")]


The author and email can be yours.

lock9

Hello,
Some extra feedback:

This example will only work with C#. It would be helpful if there were examples that didn't use inheritance.
The following contract can't receive payments. I would one that uses the user data parameter.

examples/Example.SmartContract.NonDivisibleNEP11/SampleNonDivisibleNEP11.cs

lock9 · 2024-04-03T16:43:50Z

examples/Example.SmartContract.NonDivisibleNEP11/SampleNonDivisibleNEP11.cs

+                throw new InvalidOperationException("No Authorization!");
+            for (uint i = 0; i < royaltyInfos.Length; i++)
+            {
+                if (((UInt160)royaltyInfos[i]["royaltyRecipient"]).IsValid == false ||


Royalties are not part of the NEP-11 standard. Isn't this going to confuse people?

examples/Example.SmartContract.NonDivisibleNEP11/SampleNonDivisibleNEP11.cs

AnnaShaleva · 2024-04-04T20:42:13Z

examples/Example.SmartContract.NonDivisibleNEP11/SampleNonDivisibleNEP11.cs

+                throw new InvalidOperationException("No Authorization!");
+            for (uint i = 0; i < royaltyInfos.Length; i++)
+            {
+                if (((UInt160)royaltyInfos[i]["royaltyRecipient"]).IsValid == false ||


I think we should either add a comment to the contract code that it (additionally) implements neo-project/proposals#155 or we should create one more separate example that includes Royalty standard implementation (and remove this royalty-related code from this contract).

examples/Example.SmartContract.NonDivisibleNEP11/SampleNonDivisibleNEP11.cs

Royalty example

Jim8y · 2024-04-11T09:46:26Z

@AnnaShaleva please check it again, the name has being updated.

Jim8y · 2024-04-11T09:46:56Z

please relove conflict @vikkkko

fix solution

superboyiii · 2024-04-11T10:29:48Z

All done. Ready for merge.

cschuchardt88 · 2024-04-11T21:03:20Z

...e.SmartContract.SampleRoyaltyNEP11Token/Example.SmartContract.SampleRoyaltyNEP11Token.csproj

+    <TargetFramework>net8.0</TargetFramework>
+    <Nullable>enable</Nullable>
+  </PropertyGroup>
+


This won't generate the *.nef file.

This won't generate the *.nef file.

If you want, we can add PostBuild in Target like:

<Target Name="PostBuild" AfterTargets="PostBuildEvent"> <Message Text="Start NeoContract converter, Source File: $(TargetPath)" Importance="high"> </Message> <Exec Command="nccs "$(ProjectPath)"" /> </Target>

But maybe just keep in the same formation with other examples is better? People can go to project path and just type ncss.

We should add it in all of them, but I think that we should find a different way to execute nccs, using a package we can do it without require user installation maybe.

(Not related to this PR)

examples/Example.SmartContract.SampleRoyaltyNEP11Token/SampleRoyaltyNEP11Token.cs

Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>

shargon · 2024-04-12T11:51:33Z

examples/Example.SmartContract.SampleRoyaltyNEP11Token/SampleRoyaltyNEP11Token.cs

+        {
+            if (IsOwner() == false)
+                throw new InvalidOperationException("No Authorization!");
+            if (newOwner != null && newOwner.IsValid && newOwner.IsZero == false)


It's better to use an assert, otherwise if the validation fail, the user don't get any error

if (myValueIsgood){ Action }

If your value is bad, you get the same result, the user should check the storage changes after any call?

examples/Example.SmartContract.SampleRoyaltyNEP11Token/SampleRoyaltyNEP11Token.cs

fix Assert

superboyiii · 2024-04-16T10:46:47Z

@shargon All done

Jim8y · 2024-04-17T00:26:39Z

this is an example and unnecessarily blocked the proposal. exception or assert all make sense, not worth a debating here. Thus, i will merge.

Not necessary

roman-khimov · 2024-04-17T06:55:03Z

this is an example

Yeah, this is an example and examples get copy-pasted into production code. Which means https://github.com/neo-project/neo-devpack-dotnet/pull/1009/files#r1562443533 will soon be in many C# NEP-11 implementations. And people will refer to this as the way to do things even though we know it's not the best one.

shargon · 2024-04-17T07:13:07Z

this is an example

Yeah, this is an example and examples get copy-pasted into production code. Which means https://github.com/neo-project/neo-devpack-dotnet/pull/1009/files#r1562443533 will soon be in many C# NEP-11 implementations. And people will refer to this as the way to do things even though we know it's not the best one.

I can't agree more, an example in the official repository is not an example, it is a template

Jim8y · 2024-04-18T01:31:01Z

Yeah, this is an example and examples get copy-pasted into production code. Which means https://github.com/neo-project/neo-devpack-dotnet/pull/1009/files#r1562443533 will soon be in many C# NEP-11 implementations. And people will refer to this as the way to do things even though we know it's not the best one.

�I wont block your best one example practice if you have one in your mind. But blocking a pr without telling what is your best practice is not ok for me. And i sort of not believing there exists a best one example, discussion here more like either or.

vikkkko added 2 commits March 29, 2024 14:25

add example nep11

2353d01

Merge branch 'master' into master

e630e04

superboyiii mentioned this pull request Mar 29, 2024

Add Royalty standard neo-project/proposals#155

Merged

vncoelho reviewed Mar 29, 2024

View reviewed changes

cschuchardt88 requested changes Mar 30, 2024

View reviewed changes

Jim8y and others added 2 commits March 31, 2024 14:55

Update examples/Example.SmartContract.NEP11/Example.SmartContract.NEP…

7d027ab

…11.csproj Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>

change name and change storage usage

f990047

shargon reviewed Apr 2, 2024

View reviewed changes

superboyiii and others added 4 commits April 3, 2024 16:02

multi-fix

fd3ead6

more fix

75f90a6

owner revert

eb45055

Merge pull request #1 from superboyiii/royalty-example

f91407b

Royalty example

Jim8y reviewed Apr 3, 2024

View reviewed changes

examples/Example.SmartContract.NonDivisibleNEP11/SampleNonDivisibleNEP11.cs Outdated Show resolved Hide resolved

Update examples/Example.SmartContract.NonDivisibleNEP11/SampleNonDivi…

142e931

…sibleNEP11.cs

Jim8y reviewed Apr 3, 2024

View reviewed changes

examples/Example.SmartContract.NonDivisibleNEP11/SampleNonDivisibleNEP11.cs Outdated Show resolved Hide resolved

Update examples/Example.SmartContract.NonDivisibleNEP11/SampleNonDivi…

4ba9fc6

…sibleNEP11.cs

Jim8y reviewed Apr 3, 2024

View reviewed changes

examples/Example.SmartContract.NonDivisibleNEP11/SampleNonDivisibleNEP11.cs Outdated Show resolved Hide resolved

Update examples/Example.SmartContract.NonDivisibleNEP11/SampleNonDivi…

ff66e79

…sibleNEP11.cs

Jim8y reviewed Apr 3, 2024

View reviewed changes

examples/Example.SmartContract.NonDivisibleNEP11/SampleNonDivisibleNEP11.cs Outdated Show resolved Hide resolved

Update examples/Example.SmartContract.NonDivisibleNEP11/SampleNonDivi…

f6b0b92

…sibleNEP11.cs

Jim8y reviewed Apr 3, 2024

View reviewed changes

examples/Example.SmartContract.NonDivisibleNEP11/SampleNonDivisibleNEP11.cs Outdated Show resolved Hide resolved

Update examples/Example.SmartContract.NonDivisibleNEP11/SampleNonDivi…

f363da5

…sibleNEP11.cs

Jim8y reviewed Apr 3, 2024

View reviewed changes

lock9 reviewed Apr 3, 2024

View reviewed changes

Merge branch 'master' into master

bda7481

AnnaShaleva reviewed Apr 4, 2024

View reviewed changes

fix name and comment

5716d0c

superboyiii and others added 4 commits April 11, 2024 17:35

fix

81c2515

fix

6a89ce4

fix update

653226e

Merge pull request #3 from superboyiii/royalty-example

7d97d18

Royalty example

vikkkko and others added 3 commits April 11, 2024 17:57

Merge branch 'master' into master

e73558f

fix solution

3aba116

Merge pull request #4 from superboyiii/royalty-example

ca1f14f

fix solution

cschuchardt88 previously requested changes Apr 11, 2024

View reviewed changes

Update SampleRoyaltyNEP11Token.cs

d6ef385

Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>

Jim8y previously approved these changes Apr 12, 2024

View reviewed changes

shargon reviewed Apr 12, 2024

View reviewed changes

Apply suggestions from code review

dbbf66c

cschuchardt88 dismissed Jim8y’s stale review via dbbf66c April 15, 2024 19:57

Merge branch 'master' into master

eac9d27

Jim8y previously approved these changes Apr 16, 2024

View reviewed changes

superboyiii and others added 2 commits April 16, 2024 18:43

fix Assert

ef7c040

Merge pull request #5 from superboyiii/royalty-example

a330c74

fix Assert

vikkkko dismissed Jim8y’s stale review via a330c74 April 16, 2024 10:46

Jim8y approved these changes Apr 17, 2024

View reviewed changes

Jim8y merged commit 35ee6f5 into neo-project:master Apr 17, 2024
3 checks passed

shargon mentioned this pull request Apr 17, 2024

Throw error when wrong inputs #1022

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add example nep11 #1009

add example nep11 #1009

vikkkko commented Mar 29, 2024

vncoelho left a comment

Jim8y commented Mar 29, 2024

cschuchardt88 left a comment

cschuchardt88 commented Mar 30, 2024

vikkkko commented Apr 1, 2024

shargon Apr 2, 2024

shargon Apr 2, 2024

superboyiii Apr 3, 2024

lock9 Apr 3, 2024

AnnaShaleva Apr 4, 2024

shargon Apr 2, 2024

shargon Apr 2, 2024

lock9 Apr 3, 2024

shargon Apr 2, 2024

Jim8y Apr 3, 2024

lock9 left a comment

lock9 Apr 3, 2024

AnnaShaleva Apr 4, 2024

Jim8y commented Apr 11, 2024

Jim8y commented Apr 11, 2024

superboyiii commented Apr 11, 2024 •

edited

Loading

cschuchardt88 Apr 11, 2024

superboyiii Apr 12, 2024

shargon Apr 12, 2024 •

edited

Loading

shargon Apr 12, 2024

cschuchardt88 Apr 15, 2024

shargon Apr 16, 2024

superboyiii commented Apr 16, 2024

Jim8y commented Apr 17, 2024

roman-khimov commented Apr 17, 2024

shargon commented Apr 17, 2024

Jim8y commented Apr 18, 2024 •

edited

Loading

	if (newOwner != null && newOwner.IsValid)
	if (newOwner != null && newOwner.IsValid && !newOwner.IsZero)

add example nep11 #1009

add example nep11 #1009

Conversation

vikkkko commented Mar 29, 2024

vncoelho left a comment

Choose a reason for hiding this comment

Jim8y commented Mar 29, 2024

cschuchardt88 left a comment

Choose a reason for hiding this comment

cschuchardt88 commented Mar 30, 2024

vikkkko commented Apr 1, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lock9 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Jim8y commented Apr 11, 2024

Jim8y commented Apr 11, 2024

superboyiii commented Apr 11, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shargon Apr 12, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

superboyiii commented Apr 16, 2024

Jim8y commented Apr 17, 2024

roman-khimov commented Apr 17, 2024

shargon commented Apr 17, 2024

Jim8y commented Apr 18, 2024 • edited Loading

superboyiii commented Apr 11, 2024 •

edited

Loading

shargon Apr 12, 2024 •

edited

Loading

Jim8y commented Apr 18, 2024 •

edited

Loading