Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Framework Add] implement payable #990
[Framework Add] implement payable #990
Changes from 4 commits
cb0e876
729414c
a83423a
5534919
a1a950a
8795eeb
c8273ea
f37b86d
8670f71
9148455
8767b34
213e3b1
049ba8a
bcf35f0
b96f968
027d399
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parameter names should also be checked, they are a part of the standard. Take a look at https://github.com/nspcc-dev/neo-go/blob/319880e2014ebbe8abd8ce58dcf212869c22604b/pkg/smartcontract/manifest/standard/comply.go#L68.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be very strict, maybe we want to call to our token
myTokenId
, I think that names are not neededThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roman-khimov, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking of
transfer(to Hash160, from Hash160, amount Integer, id ByteString, _ Any)
andComply()
preventing it.Check warning on line 12 in tests/Neo.SmartContract.Framework.TestContracts/Contract_SupportedStandard11Payable.cs
GitHub Actions / Test
Check warning on line 12 in tests/Neo.SmartContract.Framework.TestContracts/Contract_SupportedStandard11Payable.cs
GitHub Actions / Test
Check warning on line 12 in tests/Neo.SmartContract.Framework.TestContracts/Contract_SupportedStandard17Payable.cs
GitHub Actions / Test
Check warning on line 12 in tests/Neo.SmartContract.Framework.TestContracts/Contract_SupportedStandard17Payable.cs
GitHub Actions / Test