-
Notifications
You must be signed in to change notification settings - Fork 224
Enable private key import in initial wallet creation #815
Conversation
If there is no address in the wallet, the password is removed too. |
No, wallet need password, it's a container which is for later import. Like a server, even no app is running, you should set up username and password first. |
The password is not stored in the wallet, but is used to encrypt the private keys. If you remove all the addresses, then the password is removed from the wallet too. |
How about asking double confirm password when open an empty wallet? I'm worried about someone use an incorrect password to open the wallet and import a real privatekey, then the incorrect password becomes the correct. |
@superboyiii why you need an empty wallet? |
Someone imports Neo Legacy's privatekey to N3 wallet but have to create an unused address as the default address, it's strange. |
@erikzhang @shargon Could you review again? I make a double pwd check when open an empty wallet in case someone imports privatekey but forget the previous password. |
@superboyiii maybe it's better to create a new command for import for neo legacy? |
@erikzhang @shargon Pls review again. |
@shargon @erikzhang Ready for review. |
Close #814
Require neo-project/neo#2580