-
Notifications
You must be signed in to change notification settings - Fork 146
Conversation
@igormcoelho Works as expected, this project require a format |
We still need to manually fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there, let's just manually fix that one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good now.
Codecov Report
@@ Coverage Diff @@
## master #198 +/- ##
=======================================
Coverage 79.32% 79.32%
=======================================
Files 16 16
Lines 1422 1422
=======================================
Hits 1128 1128
Misses 294 294
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for me, if travis tests pass that's fine.
This one has no rush I guess... let's wait for more interactions here.
why pass with wrong lf? |
Anyone could review this pull request? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay @shargon, we will revise asap and check the format. The travis is good to me since we already checked that before.
This will prevent to push any format error
Related to neo-project/neo#982