Skip to content
This repository has been archived by the owner on Nov 22, 2023. It is now read-only.

Check dotnet format in travis #198

Merged
merged 16 commits into from
Sep 13, 2019
Merged

Check dotnet format in travis #198

merged 16 commits into from
Sep 13, 2019

Conversation

shargon
Copy link
Member

@shargon shargon commented Aug 25, 2019

This will prevent to push any format error

Related to neo-project/neo#982

@shargon
Copy link
Member Author

shargon commented Aug 25, 2019

@igormcoelho Works as expected, this project require a format

@shargon shargon requested review from lock9 and vncoelho August 25, 2019 13:01
@vncoelho
Copy link
Member

We still need to manually fix tests/neo-vm.Tests/UtDebugger.cs

Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, let's just manually fix that one

vncoelho
vncoelho previously approved these changes Aug 26, 2019
Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good now.

@codecov-io
Copy link

codecov-io commented Aug 26, 2019

Codecov Report

Merging #198 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #198   +/-   ##
=======================================
  Coverage   79.32%   79.32%           
=======================================
  Files          16       16           
  Lines        1422     1422           
=======================================
  Hits         1128     1128           
  Misses        294      294
Impacted Files Coverage Δ
src/neo-vm/Types/Integer.cs 78.12% <ø> (ø) ⬆️
src/neo-vm/ExecutionEngine.cs 70.79% <ø> (ø) ⬆️
src/neo-vm/Types/Array.cs 53.57% <ø> (ø) ⬆️
src/neo-vm/Types/Map.cs 37.28% <ø> (ø) ⬆️
src/neo-vm/Instruction.cs 100% <ø> (ø) ⬆️
src/neo-vm/Script.cs 100% <ø> (ø) ⬆️
src/neo-vm/RandomAccessStack.cs 100% <ø> (ø) ⬆️
src/neo-vm/ScriptBuilder.cs 100% <ø> (ø) ⬆️
src/neo-vm/Debugger.cs 96.92% <ø> (ø) ⬆️
src/neo-vm/Types/Struct.cs 100% <ø> (ø) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fd56dd...be51ea9. Read the comment docs.

igormcoelho
igormcoelho previously approved these changes Aug 27, 2019
Copy link
Contributor

@igormcoelho igormcoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me, if travis tests pass that's fine.

This one has no rush I guess... let's wait for more interactions here.

@shargon
Copy link
Member Author

shargon commented Aug 27, 2019

why pass with wrong lf?

.editorconfig Outdated Show resolved Hide resolved
@shargon
Copy link
Member Author

shargon commented Sep 6, 2019

Anyone could review this pull request?

Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay @shargon, we will revise asap and check the format. The travis is good to me since we already checked that before.

@lock9 lock9 merged commit 11dc29c into master Sep 13, 2019
@erikzhang erikzhang deleted the dotnet-format branch November 20, 2019 04:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants