Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change json fields to all lower case for consistency #1736

Merged
merged 4 commits into from
Jul 2, 2020
Merged

Change json fields to all lower case for consistency #1736

merged 4 commits into from
Jul 2, 2020

Conversation

joeqian10
Copy link
Contributor

Close #261.

shargon
shargon previously approved these changes Jun 29, 2020
View reviewed changes
@erikzhang
Copy link
Member

We don't need the underlines _.

@joeqian10 joeqian10 changed the title Change json fields to snake case for consistency Change json fields to all lower case for consistency Jun 29, 2020
@shargon
Copy link
Member

shargon commented Jun 29, 2020

We don't need the underlines _.

You don't like it in camelCase?

@erikzhang
Copy link
Member

You don't like it in camelCase?

In fact, I think some words look good in camelCase, some are not. Maybe we don't have to keep all json keys in a consistent style.

@roman-khimov
Copy link
Contributor

Maybe we don't have to keep all json keys in a consistent style.

Whatever that would be, please, let's keep it consistent across Neo.

I don't have any particular preference and I don't think there is any better or worse choice here, so it'd be quite natural for us to just minimize the amount of changes and mostly stick to the style already set by Neo 2 RPC. But be consistent. Code vs. documentation and various Neo subsystems against each other.

shargon
shargon approved these changes Jun 29, 2020
View reviewed changes
Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer camelcase, but i am not agains this style

@Tommo-L
Copy link
Contributor

Tommo-L commented Jul 2, 2020

Merge? It good for me, sine our NEP#ABI and NEP#Manifest all use lower case style.

@vncoelho
Copy link
Member

vncoelho commented Jul 2, 2020

@shargon, I prefer camelcase too and I share the same vision of not being against.

@Tommo-L
Copy link
Contributor

Tommo-L commented Jul 2, 2020

😂 Okay, since most people like camelcase, could @joeqian10 help adjust them?

@joeqian10
Copy link
Contributor Author

Personally I like all lower case too! I think PascalCase is even better than camelCase from the aesthetics view. @erikzhang @shargon @roman-khimov @vncoelho @Tommo-L If you are all ok with lower case (maybe it's not your favorite), then let's keep it and make other sub systems consistent, because I'm tired of discussing and changing this one more time. We have more meaningful issues to fix.

@vncoelho
Copy link
Member

vncoelho commented Jul 2, 2020

Ahahahahahaha this is already approved,lets merge this. In the future we do a complete change if necessary.

@erikzhang erikzhang merged commit 76448e1 into neo-project:master Jul 2, 2020
@shargon shargon mentioned this pull request Jul 2, 2020
Merged
@Tommo-L Tommo-L mentioned this pull request Jul 2, 2020
Closed
ShawnYun pushed a commit to ShawnYun/neo that referenced this pull request Jul 6, 2020
@joeqian10 @ShawnYun
Change json fields to all lower case for consistency (neo-project#1736)
49b713d
shargon added a commit that referenced this pull request Jul 22, 2020
@ZhangTao1596 @erikzhang
@shargon @devhawk @Tommo-L @joeqian10
[neox] Merge master (#1788)
3a0a732 
* Allow call from native contract (#1700)

* Fix MethodCallback (#1723)

* Fix #1714 (#1715)

* Add base64 SYSCALLs (#1717)

* Neo.VM.3.0.0-CI00230 (#1725)

* Allow to iterate buffer (#1726)

* Buffer iterator

* Rename

* Remove using

Co-authored-by: Erik Zhang <erik@neo.org>

* Update StorageContext.cs (#1728)

StorageContext needs to be public so it can be accessed by Neo Debugger

Co-authored-by: Erik Zhang <erik@neo.org>

* Fix return value check (#1730)

Co-authored-by: Shargon <shargon@gmail.com>

* Fix ContractEventDescriptor (#1733)

* fix enumerator (#1744)

Co-authored-by: Tommo-L <luchuan@neo.org>

* Change json fields to all lower case for consistency (#1736)

* Replace DataCache.Find by DataCache.Seek (#1740)

* replace DataCache.Find by DataCache.Seek

* fix order

* optimize

* Update ByteArrayComparer.cs

* Update ByteArrayComparer.cs

* Update DataCache.cs

* fix comments

* fix comments

* fix comments

* Update DataCache.cs

* Update DataCache.cs

* Reorder methods

Co-authored-by: Tommo-L <luchuan@neo.org>
Co-authored-by: erikzhang <erik@neo.org>
Co-authored-by: Shargon <shargon@gmail.com>

* Add MaxVerificationGas (#1745)

Co-authored-by: Shargon <shargon@gmail.com>

* Create KeyBuilder (#1748)

* Speed up the initialization of ApplicationEngine. (#1749)

* Change nef checksum to double SHA256 (#1751)

* Change to double SHA256

* Clean code

* Revert change

* Clean code

* Fix checksum

* Update NefFile.cs

* Fix compile

* Clean code

Clean code
Fix checksum
Update NefFile.cs
Fix compile

* Optimize

* Optimize

* Fix

Co-authored-by: erikzhang <erik@neo.org>

* Check witnesses on isStandard (#1754)

* Check witness on isStandard

* Add IsDeployed

* Add IsPayable

* Fix UT

* format

* Add coverage

* Remove IsPayable, IsDeployed

* Move NEP10 to manifest (#1729)

* NEP10 abi

* To lower case

* Move to Manifest

* Clean code

* Update ContractManifest.cs

* Update ContractManifest.cs

* Fix native contracts

Co-authored-by: Erik Zhang <erik@neo.org>

* Capture fault Exception (#1761)

* Capture faultException

* Update Wallet error

* Remove flag check

* Clean code

* Sender from signers (#1752)

* Sender from signers

* Remove co-

* Move signers outside attributes

* Fix UT and remove Signers class

* Fix UT

* Add FeeOnly scope

* Remove orderBy

* Remove _signersCache

* Fix Signers

* Fix WitnessScope

* Fix Sender

* Update TransactionAttributeType.cs

* Update Wallet.cs

* Fix Wallet

* Rename

* Update Wallet.cs

* Update Wallet.cs

* Partial UT fix

* More UT fixes

* Fix Sender's WitnessScope

* Fix Wallet

* Fix UT

* Explicit FeeOnly for DeployNativeContracts

* Same order as serialization

* Test FeeOnly

* dotnet format

* format

Co-authored-by: Erik Zhang <erik@neo.org>

* IApplicationEngineProvider (#1758)

* Remove the lock from SendersFeeMonitor and rename it to TransactionVerificationContext (#1756)

* Add EffectiveVoterTurnout (#1762)

* Remove AllowedTriggers from SYSCALLs (#1755)

* fix validatorscount (#1770)

Co-authored-by: Tommo-L <luchuan@neo.org>

* impl SeekInternal

Co-authored-by: Erik Zhang <erik@neo.org>
Co-authored-by: Shargon <shargon@gmail.com>
Co-authored-by: Harry Pierson <harrypierson@hotmail.com>
Co-authored-by: Luchuan <luchuan@ngd.neo.org>
Co-authored-by: Tommo-L <luchuan@neo.org>
Co-authored-by: joeqian <qianzhuo@ngd.neo.org>
shargon added a commit that referenced this pull request Jul 23, 2020
@ZhangTao1596 @erikzhang
@shargon @devhawk @Tommo-L @joeqian10 @cloud8little @Qiao-Jin
[neox] Merge master (#1789)
857bfec 
* Allow call from native contract (#1700)

* Fix MethodCallback (#1723)

* Fix #1714 (#1715)

* Add base64 SYSCALLs (#1717)

* Neo.VM.3.0.0-CI00230 (#1725)

* Allow to iterate buffer (#1726)

* Buffer iterator

* Rename

* Remove using

Co-authored-by: Erik Zhang <erik@neo.org>

* Update StorageContext.cs (#1728)

StorageContext needs to be public so it can be accessed by Neo Debugger

Co-authored-by: Erik Zhang <erik@neo.org>

* Fix return value check (#1730)

Co-authored-by: Shargon <shargon@gmail.com>

* Fix ContractEventDescriptor (#1733)

* fix enumerator (#1744)

Co-authored-by: Tommo-L <luchuan@neo.org>

* Change json fields to all lower case for consistency (#1736)

* Replace DataCache.Find by DataCache.Seek (#1740)

* replace DataCache.Find by DataCache.Seek

* fix order

* optimize

* Update ByteArrayComparer.cs

* Update ByteArrayComparer.cs

* Update DataCache.cs

* fix comments

* fix comments

* fix comments

* Update DataCache.cs

* Update DataCache.cs

* Reorder methods

Co-authored-by: Tommo-L <luchuan@neo.org>
Co-authored-by: erikzhang <erik@neo.org>
Co-authored-by: Shargon <shargon@gmail.com>

* Add MaxVerificationGas (#1745)

Co-authored-by: Shargon <shargon@gmail.com>

* Create KeyBuilder (#1748)

* Speed up the initialization of ApplicationEngine. (#1749)

* Change nef checksum to double SHA256 (#1751)

* Change to double SHA256

* Clean code

* Revert change

* Clean code

* Fix checksum

* Update NefFile.cs

* Fix compile

* Clean code

Clean code
Fix checksum
Update NefFile.cs
Fix compile

* Optimize

* Optimize

* Fix

Co-authored-by: erikzhang <erik@neo.org>

* Check witnesses on isStandard (#1754)

* Check witness on isStandard

* Add IsDeployed

* Add IsPayable

* Fix UT

* format

* Add coverage

* Remove IsPayable, IsDeployed

* Move NEP10 to manifest (#1729)

* NEP10 abi

* To lower case

* Move to Manifest

* Clean code

* Update ContractManifest.cs

* Update ContractManifest.cs

* Fix native contracts

Co-authored-by: Erik Zhang <erik@neo.org>

* Capture fault Exception (#1761)

* Capture faultException

* Update Wallet error

* Remove flag check

* Clean code

* Sender from signers (#1752)

* Sender from signers

* Remove co-

* Move signers outside attributes

* Fix UT and remove Signers class

* Fix UT

* Add FeeOnly scope

* Remove orderBy

* Remove _signersCache

* Fix Signers

* Fix WitnessScope

* Fix Sender

* Update TransactionAttributeType.cs

* Update Wallet.cs

* Fix Wallet

* Rename

* Update Wallet.cs

* Update Wallet.cs

* Partial UT fix

* More UT fixes

* Fix Sender's WitnessScope

* Fix Wallet

* Fix UT

* Explicit FeeOnly for DeployNativeContracts

* Same order as serialization

* Test FeeOnly

* dotnet format

* format

Co-authored-by: Erik Zhang <erik@neo.org>

* IApplicationEngineProvider (#1758)

* Remove the lock from SendersFeeMonitor and rename it to TransactionVerificationContext (#1756)

* Add EffectiveVoterTurnout (#1762)

* Remove AllowedTriggers from SYSCALLs (#1755)

* fix validatorscount (#1770)

Co-authored-by: Tommo-L <luchuan@neo.org>

* workflows: use checkout action v2 (#1775)

* Update git workflow

* Update .github/workflows/main.yml

Co-authored-by: Erik Zhang <erik@neo.org>

Co-authored-by: Erik Zhang <erik@neo.org>

* Add cache to native contract executions V2 (#1766)

* cache v2

* More optimizations

* Policy contract optimization

* Remove interporable variable

* Two more

* Add Set

* Optimizations

* Optimize

Co-authored-by: erikzhang <erik@neo.org>

* Optimize attributes (#1774)

* Add length before compression data (#1768)

* Add length before compression

* Optimize

* Fix UT

* Add UT

* Add UT

Co-authored-by: erikzhang <erik@neo.org>

* Fix VerifyWitnesses (#1776)

* Ensure non predictable peers (#1739)

* Plugins from List to array

* Move false to init

* Fix UT

* Refactor

* Add Exception Message For CreateContract (#1787)

* Add Exception Message When Create Contract

* Add Exception Message

* Code optimization

* add UT

Co-authored-by: Shargon <shargon@gmail.com>
Co-authored-by: Qiao Jin <43407364+Qiao-Jin@users.noreply.github.com>

Co-authored-by: Erik Zhang <erik@neo.org>
Co-authored-by: Shargon <shargon@gmail.com>
Co-authored-by: Harry Pierson <harrypierson@hotmail.com>
Co-authored-by: Luchuan <luchuan@ngd.neo.org>
Co-authored-by: Tommo-L <luchuan@neo.org>
Co-authored-by: joeqian <qianzhuo@ngd.neo.org>
Co-authored-by: cloud8little <34291844+cloud8little@users.noreply.github.com>
Co-authored-by: Qiao Jin <43407364+Qiao-Jin@users.noreply.github.com>
This was referenced Jul 31, 2020
Closed
Closed
ixje added a commit to CityOfZion/neo-mamba that referenced this pull request Aug 4, 2020
@ixje
Match neo-project/neo#1736
e266095
ixje added a commit to CityOfZion/neo-mamba that referenced this pull request Aug 4, 2020
@ixje
Match neo-project/neo#1736 (#21)
74fc554
@ixje ixje mentioned this pull request May 19, 2021
Merged
snowypowers pushed a commit to CityOfZion/neon-js that referenced this pull request May 19, 2021
@ixje
fix(wallet): Rename account.isdefault to isDefault (#738)
bc9947b 
The property was initially renamed to isdefault by neo-project/neo#1736 now renamed back to isDefault by neo-project/neo#2451.

Close #736
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vncoelho vncoelho vncoelho approved these changes

@erikzhang erikzhang erikzhang approved these changes

@shargon shargon shargon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Difference between implementation and documentation of GetVersion RPC method
6 participants
@joeqian10 @erikzhang @shargon @roman-khimov @Tommo-L @vncoelho