Rename DBFT Settings

[vncoelho]

Renaming in the same way as other plugins, such as RpcServerSettings

[igormcoelho]

Ok, better naming.

[cschuchardt88]

This may break 3rd-party apps like neo-express. But good job. Changes like this for the better.

[igormcoelho]

It seems all other call "Settings".... so maybe keep that way.

[vncoelho]

We are not sure if the change if fully correct, @cschuchardt88.

We just noticed that maybe we need to set a Record to be more compatible.

[cschuchardt88]

Just make a dupe class with DBFTPluginSettings that inherits Settings. Than mark Settings as obsolete. Keeping all parameters with Settings. Than any public properties or places with DBFTPluginSettings.

I think the class constructor is the only place for Settings class. So do above. but just create another constructor like

[Obsolete("use DBFTPluginSettings class")]
public ConsensusContext(NeoSystem neoSystem, Settings settings, Wallet wallet) { }

// new way
public ConsensusContext(NeoSystem neoSystem, DBFTPluginSettings settings, Wallet wallet) { }

Than in 3.8.1 we make Settings Internal or remove it.

[vncoelho]

I think this will not be a necessary change for now, @cschuchardt88

Later we make this change

[cschuchardt88]

I think this will not be a necessary change for now, @cschuchardt88

Later we make this change

We still need this in several plugins.

[vncoelho]

I think this will not be a necessary change for now, @cschuchardt88
Later we make this change

We still need this in several plugins.

I think that we can make the change to all plugins in the same PR, then we organize this correctly!

[vncoelho]

If you want to proceed with this in another PR it will be great.