[Neo Rpc Methods] fix contact rpc methods parameters #3485
Conversation
| /// This method is used to test your VM script as if they ran on the blockchain at that point in time. | ||
| /// This RPC call does not affect the blockchain in any way. | ||
| /// </remarks> | ||
| /// <param name="scriptHash">Smart contract scripthash. Use big endian for Hash160, little endian for ByteArray.</param> |
There was a problem hiding this comment.
Use big endian for Hash160
It's LE.
There was a problem hiding this comment.
Can you check it again, cause its from the official document.
| /// <param name="useDiagnostic">Optional. Flag to enable diagnostic information.</param> | ||
| /// <returns>A JToken containing the result of the invocation.</returns> | ||
| [RpcMethodWithParams] | ||
| protected internal virtual JToken InvokeFunction(string scriptHash, string operation, ContractParameter[] args = null, Signer[] signers = null, bool useDiagnostic = false) |
There was a problem hiding this comment.
This behaviour diverges from an old one. This method should accept the list of signers with witnesses as the fourth parameter, not only the list of signers.
There was a problem hiding this comment.
It never worked. And not bing of any use at anywhere.
There was a problem hiding this comment.
And not bing of any use at anywhere.
You don't know that. It's an external API and it's a very widely used one. Your changes can easily break real applications. Refactorings must not break compatibility.
|
|
||
| namespace Neo.Plugins.RpcServer.Model; | ||
|
|
||
| public class SignerOrWitness |
There was a problem hiding this comment.
Why not make a base class for common stuff? Than two different classes one, being Signer and other being Witness. This way we can get Signer attributes like Rules or other properties that separate the two classes.
There was a problem hiding this comment.
make it work first, optimize it later. I think you are better than me to make the code more elegent.
There was a problem hiding this comment.
You may take a look at https://github.com/nspcc-dev/neo-go/blob/e1d5ac8557d7e087158e6a766d059913a56df79f/pkg/neorpc/types.go#L75 and https://github.com/nspcc-dev/neo-go/blob/e1d5ac8557d7e087158e6a766d059913a56df79f/pkg/neorpc/types.go#L83 as a reference, both Signer and Witness should be accepted at the same time.
|
@AnnaShaleva please check latest update to make it |
| throw new RpcException(CreateInvalidParamError<Signer>(token)); | ||
| } | ||
| } | ||
| throw new RpcException(CreateInvalidParamError<Signer>(token)); |
There was a problem hiding this comment.
Would adding an else statement here make it clearer?
|
|
||
| namespace Neo.Plugins.RpcServer.Model; | ||
|
|
||
| public class SignerWithWitness(Signer? signer, Witness? witness) |
There was a problem hiding this comment.
It would be nice to fix the linter comment.
| }).ToArray(); | ||
| } | ||
|
|
||
| private static UInt160 AddressToScriptHash(string address, byte version) |
There was a problem hiding this comment.
I thought we already had this helper somewhere else. If so, can we reuse the existing helper?
| return new[] { signerOrWitness }; | ||
| } | ||
| } | ||
| throw new RpcException(RpcError.InvalidParams.WithData($"Invalid SignerOrWitness format: {token}")); |
| /// This method is used to test your VM script as if they ran on the blockchain at that point in time. | ||
| /// This RPC call does not affect the blockchain in any way. | ||
| /// </remarks> | ||
| /// <param name="scriptHash">Smart contract scripthash. Use big endian for Hash160, little endian for ByteArray.</param> |
|
@AnnaShaleva updated this pr to mock the complete http request process, now should be able to work without miss any detail. |
Description
This pr updates the rpc plugin contract related methods.
Fixes # (issue)
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: