Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak on TaskManager due to continuous growth of knownHashes (3.x) #871

Merged
merged 1 commit into from
Jun 26, 2019
Merged

Fix memory leak on TaskManager due to continuous growth of knownHashes (3.x) #871

merged 1 commit into from
Jun 26, 2019

Conversation

vncoelho
Copy link
Member

No description provided.

igormcoelho
igormcoelho approved these changes Jun 26, 2019
View reviewed changes
Copy link
Contributor

@igormcoelho igormcoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change.

@codecov-io
Copy link

codecov-io commented Jun 26, 2019 •
edited
Loading

Codecov Report

Merging #871 into master will increase coverage by 0.03%.
The diff coverage is 15.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #871      +/-   ##
==========================================
+ Coverage   43.53%   43.56%   +0.03%     
==========================================
  Files         177      177              
  Lines       12566    12578      +12     
==========================================
+ Hits         5471     5480       +9     
- Misses       7095     7098       +3
Impacted Files Coverage Δ
neo/IO/Caching/FIFOSet.cs 22.85% <0%> (+22.85%) ⬆️
neo/Network/P2P/TaskManager.cs 19.44% <100%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c0e895...79c7267. Read the comment docs.

@vncoelho
Copy link
Member Author

Even the coverage increased! :D ahueahuea

@vncoelho vncoelho merged commit d664be6 into master Jun 26, 2019
@vncoelho vncoelho deleted the fix-leak-knownhashes-TaskManager-3.0 branch June 26, 2019 15:35
Thacryba pushed a commit to simplitech/neo that referenced this pull request Feb 17, 2020
@Celia18305
修复几个Bug (neo-project#871)
a7fd766
Tommo-L pushed a commit to Tommo-L/neo that referenced this pull request Jun 22, 2020
@vncoelho @Tommo-L
Fix memory leak on TaskManager due to continuous growth of knownHashe…
41ae0e3 
…s (3.0) (neo-project#871)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shargon shargon shargon approved these changes

@igormcoelho igormcoelho igormcoelho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vncoelho @codecov-io @igormcoelho @shargon