Merge pull request #744 from oskarhane/editor-lint-toggle

Add non-visible config `editorLint` to toggle editor linting
neo4j · Apr 27, 2018 · 5462db5 · 5462db5
2 parents 8e8ff20 + baf676d
commit 5462db5
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/src/browser/modules/Editor/Editor.jsx b/src/browser/modules/Editor/Editor.jsx
@@ -38,7 +38,8 @@ import {
 import { getHistory } from 'shared/modules/history/historyDuck'
 import {
   getCmdChar,
-  shouldEditorAutocomplete
+  shouldEditorAutocomplete,
+  shouldEditorLint
 } from 'shared/modules/settings/settingsDuck'
 import { Bar, ActionButtonSection, EditorWrapper } from './styled'
 import { EditorButton, EditModeEditorButton } from 'browser-components/buttons'
@@ -321,7 +322,7 @@ export class Editor extends Component {
       autofocus: true,
       smartIndent: false,
       lineNumberFormatter: this.lineNumberFormatter.bind(this),
-      lint: true,
+      lint: this.props.enableEditorLint,
       extraKeys: {
         'Ctrl-Space': 'autocomplete',
         Enter: this.handleEnter.bind(this),
@@ -439,6 +440,7 @@ const mapDispatchToProps = (dispatch, ownProps) => {
 const mapStateToProps = state => {
   return {
     enableEditorAutocomplete: shouldEditorAutocomplete(state),
+    enableEditorLint: shouldEditorLint(state),
     history: getHistory(state),
     cmdchar: getCmdChar(state),
     schema: {

diff --git a/src/shared/modules/settings/__snapshots__/settingsDuck.test.js.snap b/src/shared/modules/settings/__snapshots__/settingsDuck.test.js.snap
@@ -6,6 +6,7 @@ Object {
   "browserSyncDebugServer": null,
   "cmdchar": ":",
   "editorAutocomplete": true,
+  "editorLint": false,
   "initCmd": ":play start",
   "initialNodeDisplay": 300,
   "maxFrames": 30,

diff --git a/src/shared/modules/settings/settingsDuck.js b/src/shared/modules/settings/settingsDuck.js
@@ -43,6 +43,7 @@ export const getInitialNodeDisplay = state =>
 export const getScrollToTop = state => state[NAME].scrollToTop
 export const shouldReportUdc = state => state[NAME].shouldReportUdc !== false
 export const shouldAutoComplete = state => state[NAME].autoComplete !== false
+export const shouldEditorLint = state => state[NAME].editorLint === true
 
 const browserSyncConfig = (host = 'https://auth.neo4j.com') => ({
   authWindowUrl: `${host}/indexNewBrowser.html`,
@@ -77,6 +78,7 @@ const initialState = {
   scrollToTop: true,
   maxFrames: 30,
   editorAutocomplete: true,
+  editorLint: false,
   useCypherThread: true
 }