Format node/relationship counts in sidebar, inspector and legend #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 4, 2019 16:22
… created. naming needs looking at.
jk05
commented
Dec 5, 2019
jk05
commented
Dec 5, 2019
| @@ -64,7 +65,7 @@ const createItems = ( | |||
| if (showStar) { | |||
| let str = '*' | |||
| if (count) { | |||
| str = `${str}(${count})` | |||
| str = `${str}(${thousandsCommaSeparatedNumber(count)})` | |||
There was a problem hiding this comment.
I did this here as I assume we would always want to comma separate whenever createItems is called...
jk05
commented
Dec 5, 2019
| * | ||
| */ | ||
|
|
||
| export default value => |
There was a problem hiding this comment.
Im going to have another look at this, but the general thought process is for defensive purposes but I dont know how defensive we need to be here
parseIntto coerce everything to numbers, but need to do theisNaNcheck for null etc
It reads a bit odd anyway but open to suggestions, I will take another look in a bit
…nd rework the function with logical operators
jk05
commented
Dec 5, 2019
oskarhane
reviewed
Dec 5, 2019
jk05
changed the title
jk05
changed the title
added 2 commits
December 5, 2019 15:25
…t path, added additional tests and reworked number-to-US-locale.js to allow 0 to be output as string to be consistent with other values
…l mock for node and relationship values
|
would it be possible to make the formatting rendering only? so that when someone copies the number it's just the raw number? also it would be amazing to add the counts to the other labels and rel-types too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #953