Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add help cards for security commands #1027

Merged
merged 2 commits into from
Jan 2, 2020
Merged

Add help cards for security commands #1027

merged 2 commits into from
Jan 2, 2020

Conversation

nglgzz
Copy link
Member

@nglgzz nglgzz commented Dec 23, 2019

Adds help cards for the following commands:

  • ALTER USER
  • SHOW ROLES
  • [CREATE|GRANT|REVOKE|DROP] ROLE
  • SHOW PRIVILEGES
  • GRANT
  • DENY
  • REVOKE

Links to the help cards are also added into a new section of the :help cypher result card.

image

changelog: Add new Cypher syntax to :help cypher

@nglgzz nglgzz requested review from oskarhane and jk05 December 23, 2019 10:24
page="/administration/security/administration/#administration-security-administration-database-privileges"
minVersion="4.0.0"
>
Database administration
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume there isnt a specific DENY section?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see there are a few others like this too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct. GRANT, DENY, and REVOKE are together in two different sections. One for DB administration (limiting access to specific databases), and the other one for subgraph administration (limiting what kind of queries a role can do).

<>
<p>
The <code>GRANT</code> command allows an administrator to grant a
privilege to a role in order to access an entity.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

entity seems vague. I assume its in the documentation like this too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is coming from the documentation. From my understanding it's vague on purpose, because entity in this context includes many different things. It can be different types of operations on a database, a type of query, or even a type of query applied to a specific type of node/relationship.

I do agree that is not so clear though. I think access is not really appropriate, as it's not just that, but other types of operations as well: traverse/read/write/match in the case of graphs, managing indexes&constraints, and other administration operations in the case of databases.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it sounds vague but its not one I can really comment on much more. I guess if you have taken it from the documentation then at least its consistent.

Copy link

@jk05 jk05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@oskarhane oskarhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@nglgzz nglgzz merged commit 0753439 into neo4j:master Jan 2, 2020
@nglgzz nglgzz deleted the security-docs branch January 2, 2020 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants