Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add :help auto + link to it from relevant errors and docs #1057

Merged
merged 3 commits into from
Jan 31, 2020

Conversation

oskarhane
Copy link
Member

A follow-up PR for #1048.

  • Add new auto help page
  • Add link to help page from USING PERIODIC COMMIT Cypher error frame
  • Add links to auto help page from other relevant help pages

Screenshot 2020-01-30 10 49 56

Screenshot 2020-01-30 10 50 01

Screenshot 2020-01-30 10 50 07

Screenshot 2020-01-30 10 49 50

const content = (
<>
<p>
The <code>:auto</code> command will send the Cypher query after is in an
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after is in should probably be after it in

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated

auto committing transaction. In general this is not recommended because of
the lack of support for auto retrying on leader switch errors in clusters.
<br />
Some query types does however need to be sent in auto-committing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small grammar change: Some query types does -> Some query types do

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated

@oskarhane
Copy link
Member Author

Thanks for the review @HerrEmil! I've addressed your comments now.

@oskarhane oskarhane merged commit 2639861 into neo4j:master Jan 31, 2020
@oskarhane oskarhane deleted the help-auto branch January 31, 2020 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants