Fix re-run for Cypher queries to target original DB #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskarhane
force-pushed
the
rerun-same-db
branch
from
9680f5d to
7072930
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made
Wrongfully we assumed that the target DB always should be the globally selected one. This was not a valid assumption and this PR fixes that.
Now a command action object can target a specific DB.
I refactored the arguments to our
readTransaction,writeTransaction, anddirectTransactionto take an options object instead of just adding more args.Unit tests for when using web workers and not + e2e tests included.
Reproduce the bug
RETURN rand():use system