Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reacting to deep links when in Neo4j Desktop environment #1062

Merged
merged 1 commit into from
Feb 17, 2020

Conversation

oskarhane
Copy link
Member

Fixes a regression and reacts to Desktops onArgumentsChange again.
Both component tests + E2E tests added.

See it in action:
Kapture 2020-02-09 at 20 23 48-2

@oskarhane oskarhane changed the title Fix deep-links when in Neo4j Desktop environment Fix reacting to deep links when in Neo4j Desktop environment Feb 9, 2020
Copy link
Contributor

@linuslundahl linuslundahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@HerrEmil HerrEmil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🎉

@oskarhane oskarhane merged commit 13d8e0d into neo4j:master Feb 17, 2020
@oskarhane oskarhane deleted the desktop-args-change branch February 17, 2020 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants