Feature relatable #1090
Merged
Feature relatable #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huboneo
force-pushed
the
feature-relatable
branch
from
d2beb65 to
4fffe52
Compare
|
@oskarhane I have passing tests now apart from 4.1 |
oskarhane
reviewed
May 26, 2020
There was a problem hiding this comment.
Awesome, renders all types as we want it to! Nice!
Just one last thing, I think the recursive lookup for graph elements isn't working properly.
This query on the regular movies db doesn't render anything in the viz view:
MATCH (n:Person)-[r]-()
RETURN 1.0, 1, null, true, false, "hello", "<b>bold</b>", [1, "x"], {x: 1, y: "string", n: n, html: "<b>bold</b>", link: "x http://hej.com x"}, r
- Introduced new setting "maxFieldItems" - Now truncating data passed to CypherFrames whenever a field that is too large is detected - Refactored boltMapping code to increase performance - Side effect is that we now dedupe nodes, not sure if OK - fix unit test - update snapshots, add warning when fields are truncated
- Replaced TableView with RelatableView - Updated tests - Removed max field items from settings for now, use :config - Also disabled Vis when results exceed max safe limit
huboneo
force-pushed
the
feature-relatable
branch
from
17a356c to
8b58fe9
Compare
|
@oskarhane great catch, updated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new configuration option in browser for truncating max field length before they are passed to rendering layers. The reason for this is that certain queries can produce a single result with a lot of values in a given field, which we had yet to account for.
This PR also adds
@relate-by-ui/relatabletable to improve rendering performance.Finally this PR also adds a max limit before Viz is disabled as it cannot handle more than 1000 rendered nodes/relationships
STR
Screenshot
changelog: Add a more performant result table