Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add memory allocation to plan output if provided by Neo4j #1111

Merged
merged 3 commits into from
Jun 2, 2020

Conversation

oskarhane
Copy link
Member

Add output for GlobalMemory and Memory where it exists.
GlobalMemory should normally only be available on the last Produce Result and Memory can be on some of the other operators.
The query PROFILE MATCH(n) RETURN 1 should have operators that displays both variants.

See screenshot below for how it's rendered.
I also widened the operator boxes a little bit to make it fit and in general make the plan less tall.
And added E2E tests to make sure they don't disappear.

Screenshot 2020-06-01 11 09 15

@oskarhane oskarhane requested a review from HerrEmil June 1, 2020 09:34
@oskarhane oskarhane changed the title Add memory allocation to plan output Add memory allocation to plan output if provided by Neo4j Jun 2, 2020
Copy link
Contributor

@HerrEmil HerrEmil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oskarhane oskarhane merged commit 7a52c4f into neo4j:master Jun 2, 2020
@oskarhane oskarhane deleted the plan-memory branch June 2, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants