Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integer rendering in table recursively + JSON export #1126

Merged
merged 2 commits into from
Jun 25, 2020

Conversation

oskarhane
Copy link
Member

Use the existing stringifyMod function to create fake numbers out of Neo4j integers (strings witout quotes).
Add tests to lock this functionality.

Can be verified with this query:

RETURN 9907199254740991, 1416268800000, {int: 9907199254740991, ont: 1416268800000}, [9907199254740991, 1416268800000]

Before:

Screenshot 2020-06-24 11 22 21

After:

Screenshot 2020-06-24 11 23 29

Use the existing `stringifyMod` function to create fake numbers out of Neo4j integers (strings witout quotes).
Add tests to lock this functionality.
src/browser/modules/Stream/CypherFrame/helpers.js Outdated Show resolved Hide resolved
src/browser/modules/Stream/CypherFrame/helpers.js Outdated Show resolved Hide resolved
@oskarhane
Copy link
Member Author

Thanks @HerrEmil!

@oskarhane oskarhane merged commit bb59893 into neo4j:master Jun 25, 2020
@oskarhane oskarhane deleted the fix-numbers-in-table branch June 25, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants