Browser File IO - add Apollo Client and relate-scripts component in sidebar #1201
Conversation
| @@ -103,6 +103,10 @@ module.exports = { | |||
| host: '0.0.0.0', | |||
| port: 8080, | |||
| disableHostCheck: true, | |||
| hot: !helpers.isProduction | |||
| hot: !helpers.isProduction, | |||
| proxy: { | |||
There was a problem hiding this comment.
proxy for now until we use params passed from Desktop and a potential CORS issue that was being experienced
| const filePath = path.join(directory, favorite.name) | ||
| return removeFavorite({ | ||
| variables: removeProjectFileMutationVars(filePath), | ||
| update: (cache, { data: { removeProjectFile } }) => { |
| }) => ({ | ||
| id: uuid.v4(), | ||
| name, | ||
| path: directory.startsWith('.') ? SLASH : `${SLASH}${directory}`, // @todo: need to look into this |
There was a problem hiding this comment.
couldnt get this working with . which is the root returned from Relate. Had to use SLASH for now just to get it to show, will look into later as its not a blocking issue
| remote | ||
| .request('GET', `/files/${token}/${name}`) | ||
| .then(body => body.text()) | ||
| .catch(e => console.log('++err', e)) // ? |
There was a problem hiding this comment.
need to look into handling errors and what to do in next few PRs
jk05
force-pushed
the
browser-file-io
branch
from
100deb7 to
823e7dc
Compare
|
|
||
| const MyScriptsComponent = props => { | ||
| // @todo: handling loading and error?? Pass to MyScripts?? | ||
| const { loading, error, data, refetch } = useQuery(GET_PROJECT_FILES, { |
There was a problem hiding this comment.
error or loading handling suggestions welcome here
There was a problem hiding this comment.
What can cause errors? Does it only error if the connection is broken? Just thinking how serious the errors are
There was a problem hiding this comment.
network error like when connection is broken I suppose. Or errors from the graphQL endpoint
There was a problem hiding this comment.
Hm.. perhaps it's worth having an errorbanner like db not available but for network? For errors from the end point I'm not sure.. We want them in sentry eventually at least
There was a problem hiding this comment.
yeah the banner makes sense. I will look into that, I didnt look in to the error banners
| const directory = favorite.path.substring(1) // @todo: adding in SLASH to path | ||
| const filePath = path.join(directory, favorite.name) | ||
| return removeFavorite({ | ||
| variables: removeProjectFileMutationVars(filePath), |
There was a problem hiding this comment.
need to think of error handling here too
| const isMountedRef = useRef(false) | ||
|
|
||
| useEffect(() => { | ||
| isMountedRef.current = true |
There was a problem hiding this comment.
This doesn't need to be a useRef, a closure is enough. I changed it in my pr :)
Convert to ts
|
closed in favour of #1209 |
Small adjustments to the saved-scripts component here: neo4j-devtools/relate-by-ui#7, which are visible in the screenshot. Remove export/new folder and editing folder/file names in the sidebar