Frame button interaction changes #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
February 11, 2021 10:16
HerrEmil
force-pushed
the
frame-button-interactions
branch
from
5bb3659 to
2b20008
Compare
shkirando
approved these changes
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a handful of UI and interaction changes to the frame buttons;
The color of the save as favorite button and the options in the download dropdown have been changed.
Current colors:
New colors:
The save as project file option is displayed as an option in the download dropdown instead of as an icon:
The run button is replaced by a stop button while a query is running. The cancel view inside the frame also has two states to differentiate the query cancelling and query cancelled states:
When closing a frame that has been used more than once, a confirmation modal is displayed asking for confirmation and giving the option to cancel the close frame action:
A demo of the changes is available here: http://frame-button-interactions.surge.sh/