make accessing query result records in ascii view type safe #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -124,7 +128,7 @@ function Stream(props: StreamProps): JSX.Element { | |||
| stack: frameObject.stack | |||
| } | |||
|
|
|||
| let MyFrame = getFrame(frame.type) | |||
| let MyFrame = getFrame(frame.type as FrameType) | |||
There was a problem hiding this comment.
Out of scope to change frame.type to avoid the cast?
There was a problem hiding this comment.
Yes, I tried but it was not trivial to share the type unfortunately
| @@ -0,0 +1,89 @@ | |||
| /* | |||
There was a problem hiding this comment.
This file had a long time coming, thanks! 🙏
added 2 commits
February 15, 2021 12:17
# Conflicts: # src/shared/modules/requests/requestsDuck.ts
OskarDamkjaer
approved these changes
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A crash was reported when closing a frame while it is running a query, with a screenshot that showed a runtime type error when evaluating
result.records.lengthwhen result was null. I was unable to recreate exactly the error in the screenshot, but could trigger a runtime type error when evaluatingresult.records.lengthin ascii view by opening the text tab, re-running a query and closing the frame while the query was running.This PR fixes the potential type error in ascii view and also adds stricter typings to the ascii view component, requests duck file and other files connected to these files to make it easier to fix any other unknown type errors when evaluating query result in other components.
changelog: Fix bug when closing a frame with a running query