Canny Support #1282
Merged
Canny Support #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'https://neo4j-browser.canny.io/feature-requests' | ||
|
|
||
| declare global { | ||
| interface Window { |
There was a problem hiding this comment.
second global window declared in this PR, are they automatically merged? or are they only global for this file
There was a problem hiding this comment.
Typescript interfaces are merge when declare several yes, we could move this declaration to the custom file, not sure what is more structured
| const e = document.createElement('script') as HTMLScriptElement | ||
| e.type = 'text/javascript' | ||
| e.async = true | ||
| e.src = 'https://canny.io/sdk.js' |
There was a problem hiding this comment.
Now this feels pretty cursed for some reason, I guess it's not much different to a normal cdn:ed dependency
There was a problem hiding this comment.
Any suggestions on how to dispel the curse?
There was a problem hiding this comment.
I think we'll have to live with it if we want canny 🤷
OskarDamkjaer
approved these changes
Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains 5 changes:
The changes can be demoed in this sandbox: http://canny.surge.sh/