Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add workaround to squashed command palette in small cypher editors #1312

Merged
merged 2 commits into from
Mar 5, 2021
Merged

add workaround to squashed command palette in small cypher editors #1312

merged 2 commits into from
Mar 5, 2021

Conversation

HerrEmil
Copy link
Contributor

@HerrEmil HerrEmil commented Mar 4, 2021 •
edited by jharris4
Loading

Fix for squashed command palette. Demo: http://command-palette-height.surge.sh/

Before:
old

After:
new

changelog: Fix issue where Monaco command palette would be partially hidden

jharris4
jharris4 approved these changes Mar 5, 2021
View reviewed changes
Copy link
Contributor

@jharris4 jharris4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this out in multiple frames etc and resizing the browser and works well!

@HerrEmil HerrEmil merged commit 69f0f21 into neo4j:master Mar 5, 2021
@HerrEmil HerrEmil deleted the command-palette-height branch March 5, 2021 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jharris4 jharris4 jharris4 approved these changes

@OskarDamkjaer OskarDamkjaer Awaiting requested review from OskarDamkjaer

Assignees
No one assigned
Labels
changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HerrEmil @jharris4