Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add guides to sidebar #1354

Merged
merged 64 commits into from
Apr 20, 2021
Merged

Add guides to sidebar #1354

merged 64 commits into from
Apr 20, 2021

Conversation

OskarDamkjaer
Copy link
Contributor

No description provided.

@OskarDamkjaer OskarDamkjaer force-pushed the immersive_guides branch 4 times, most recently from ea3257f to ddaf6c6 Compare April 19, 2021 07:55
OskarDamkjaer
OskarDamkjaer commented Apr 19, 2021
View reviewed changes
src/browser/components/Directives.tsx Outdated Show resolved Hide resolved
src/browser/components/Directives.tsx Show resolved Hide resolved
src/browser/components/Directives.tsx Outdated Show resolved Hide resolved
src/browser/components/TabNavigation/Navigation.tsx Outdated Show resolved Hide resolved
src/browser/components/icons/Icons.tsx Outdated Show resolved Hide resolved
src/browser/modules/Carousel/Slide.tsx Outdated Show resolved Hide resolved
jharris4
jharris4 approved these changes Apr 20, 2021
View reviewed changes
Copy link
Contributor

@jharris4 jharris4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested everything I could think of, including remote guides, cypher-template, missing guides and it all worked really solidly. Great work!

@OskarDamkjaer OskarDamkjaer requested a review from jharris4 April 20, 2021 18:37
jharris4
jharris4 approved these changes Apr 20, 2021
View reviewed changes
Copy link
Contributor

@jharris4 jharris4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OskarDamkjaer OskarDamkjaer merged commit 7d1f5ef into neo4j:master Apr 20, 2021
@OskarDamkjaer OskarDamkjaer changed the title Immersive guides Guides in sidebar Apr 27, 2021
@OskarDamkjaer OskarDamkjaer changed the title Guides in sidebar Add guides in sidebar Apr 27, 2021
@OskarDamkjaer OskarDamkjaer changed the title Add guides in sidebar Add guides to sidebar Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jharris4 jharris4 jharris4 approved these changes

Assignees
No one assigned
Labels
changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OskarDamkjaer @jharris4