Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give monaco search widget proper focus #1367

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Give monaco search widget proper focus #1367

merged 1 commit into from
Apr 20, 2021

Conversation

jharris4
Copy link
Contributor

@jharris4 jharris4 commented Apr 20, 2021 •
edited
Loading

@jharris4 jharris4 requested a review from OskarDamkjaer April 20, 2021 17:54
OskarDamkjaer
OskarDamkjaer approved these changes Apr 20, 2021
View reviewed changes
Copy link
Contributor

@OskarDamkjaer OskarDamkjaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean solution! 🙏

@jharris4 jharris4 merged commit 812ffcc into neo4j:master Apr 20, 2021
@OskarDamkjaer OskarDamkjaer changed the title ignore enter/escape key from Monaco when find widget visible Give monaco search widget proper focus Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarDamkjaer OskarDamkjaer OskarDamkjaer approved these changes

Assignees
No one assigned
Labels
changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jharris4 @OskarDamkjaer