Improve styling of new sidebar guides #1406
Conversation
package.json
Outdated
| @@ -29,7 +29,6 @@ | |||
| "e2e-local": "CYPRESS_E2E_TEST_ENV=\"local\" cypress run", | |||
| "e2e-local-open": "CYPRESS_E2E_TEST_ENV=\"local\" cypress open", | |||
| "format": "prettier-eslint --write 'src/**/!(*.min).{js,jsx,ts,tsx,css,json}' 'e2e_tests/**/*.{js,jsx,ts,tsx,css,json}' 'scripts/**/*.{js,jsx,ts,tsx,css,json}' 'build_scripts/**/*.{js,jsx,ts,tsx,css,json}'", | |||
| "jest": "jest --coverage", | |||
There was a problem hiding this comment.
Without this in package.json we can run yarn jest to run jest without flags.
| @@ -3,9 +3,7 @@ import styled from 'styled-components' | |||
| export const NoBulletsUl = styled.div` | |||
| list-style-type: none; | |||
| ` | |||
| export const BulletsInsideLi = styled.li` | |||
| @@ -437,6 +437,9 @@ export const StyledSidebarSlide = styled.div.attrs({ | |||
| list-style-position: inside; | |||
| padding-left: 0; | |||
| margin-top: 0.5em; | |||
| p { | |||
| display: inline-block; | |||
There was a problem hiding this comment.
Before we added list-style-position: inside;
in a
| type DotDotDot = '...' | ||
|
|
||
| const range = (from: number, to: number) => | ||
| Array.from({ length: from ? to - from + 1 : to }, (_, i) => i + from) |
There was a problem hiding this comment.
Perhaps it's better to use the lodash range instead
| @@ -19,7 +19,7 @@ import React, { useState } from 'react' | |||
| import styled from 'styled-components' | |||
|
|
|||
| const StyledHeaderText = styled.div` | |||
| font-family: 'Open Sans'; | |||
| font-family: ${props => props.theme.drawerHeaderFontFamily}; | |||
There was a problem hiding this comment.
Adds fallback fonts, so we don't get as drastic font flashes
|
|
||
| /* global Cypress, cy, before */ | ||
|
|
||
| describe('Play command', () => { |
There was a problem hiding this comment.
Misleading name of this test suite! ;-)
| <> | ||
| {paginationHelper(itemCount, selectedIndex).map( | ||
| (slideIndexOrDots, index) => { | ||
| if (slideIndexOrDots === '...') { |
There was a problem hiding this comment.
Since you've already declared a type for this, can't you use that or a const? Feels like it'd make it easier to change the dots later if the literals weren't mixed throughout the code...
There was a problem hiding this comment.
I've considered using null instead 🤔
OskarDamkjaer
force-pushed
the
guide_polish
branch
from
954960b to
61845a4
Compare
Preview @ http://guide_polish.surge.sh
Problems addressed:
I'll annotate the source as to what solves what.