Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for home database #1410

Merged
merged 5 commits into from
May 18, 2021
Merged

Conversation

jharris4
Copy link
Contributor

@jharris4 jharris4 commented May 12, 2021

Copy link
Contributor

@OskarDamkjaer OskarDamkjaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Sys info frame seems to be missing a header. I think it should be added in sysinfo-utils.tsx on line 140.

src/browser/modules/DBMSInfo/DatabaseSelector.tsx Outdated Show resolved Hide resolved
@jharris4
Copy link
Contributor Author

@OskarDamkjaer Good catch on the missing :sysinfo header. I've pushed a fix, and verified that it now renders properly both on 4.3 and 4.0.2

@jharris4 jharris4 requested a review from OskarDamkjaer May 13, 2021 07:06
@@ -59,6 +62,9 @@ export const DatabaseSelector = ({
)
}
const uniqDatabases = uniqBy(databasesList, 'name')
const homeDb =
uniqDatabases.find((db: any) => db.home) ||
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming we don't have any neat types for this, any is fine for now

@OskarDamkjaer OskarDamkjaer changed the base branch from master to release-4.3.0 May 18, 2021 08:39
@jharris4 jharris4 merged commit c8c578c into neo4j:release-4.3.0 May 18, 2021
OskarDamkjaer pushed a commit to OskarDamkjaer/neo4j-browser that referenced this pull request May 24, 2021
* Add support for home database

* Fix sysinfo command missing home database header

* remove home column from sysinfo table

* use home emjoi for both default/home db in selector

* move emoji to end to workaround chrome spacing issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants