Fix issue where sandbox showed "Connecting.." banner even when connected #1415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works now for me, no yellow bars anymore. |
|
@OskarDamkjaer I think we should re-target this to the 4.3-release branch... |
OskarDamkjaer
force-pushed
the
conn_warning_bug
branch
from
10cf08a to
409efb2
Compare
|
I'll rebase! |
OskarDamkjaer
force-pushed
the
conn_warning_bug
branch
from
409efb2 to
048dd42
Compare
|
The changes look good to me! I'd just like to be able to reproduce the issue this fixes if possible, so I can verify the fix... |
OskarDamkjaer
force-pushed
the
conn_warning_bug
branch
from
048dd42 to
d43edff
Compare
OskarDamkjaer
force-pushed
the
conn_warning_bug
branch
from
d43edff to
f8b574d
Compare
jharris4
approved these changes
May 24, 2021
OskarDamkjaer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small PR to prevent the waiting banner from showing even though you're already connected in sandbox. I've added some types and some minor refactoring as well. The problem was not clearing setTimeout properly.