Fix plan view not updating #1451
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reusing a frame for profiling, the react lifecycle methods were written so that the component didn't update properly when it received new props. Meaning the db-hits numbers in PlanStatusBar didn't refresh as a new query was profiled.
Before:
https://user-images.githubusercontent.com/10564538/122965716-ccce0980-d388-11eb-8032-8a5d54c45505.mp4
After:
https://user-images.githubusercontent.com/10564538/122965400-6fd25380-d388-11eb-8876-7967d8a6b13a.mp4
This PR is dependent on #1445. The change intended for review is only the last commit. Preview at http://fix_plan_view_not_updating.surge.sh