Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview of SSO for browser #1478

Merged
merged 50 commits into from
Aug 10, 2021
Merged

Preview of SSO for browser #1478

merged 50 commits into from
Aug 10, 2021

Conversation

OskarDamkjaer
Copy link
Contributor

@OskarDamkjaer OskarDamkjaer commented Jul 20, 2021 •
edited
Loading

This PR borrows heavily from @tbwiss implementation of SSO for bloom.

Testing requires a lot of set up, contact me for a docker compose file if you want to test it.

@OskarDamkjaer OskarDamkjaer marked this pull request as draft July 20, 2021 12:03
@OskarDamkjaer OskarDamkjaer changed the title [WIP] SSO for browser SSO for browser Jul 27, 2021
jharris4
jharris4 reviewed Aug 2, 2021
View reviewed changes
src/shared/modules/auth/common.js Outdated
@@ -48,12 +48,15 @@ export const checkAndMergeSSOProviders = (
}

discoveredSSOProviders.forEach(provider => {
if (!provider) return
if (!provider) {
authlog(`Found invalid discoved sso provider`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

jharris4
jharris4 approved these changes Aug 9, 2021
View reviewed changes
Copy link
Contributor

@jharris4 jharris4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, would be nice to add unit tests as you said you were planning, but I leave it up to you if that's in this PR or a separate new one.

@OskarDamkjaer OskarDamkjaer marked this pull request as ready for review August 10, 2021 08:27
@OskarDamkjaer OskarDamkjaer merged commit 674cbb6 into neo4j:master Aug 10, 2021
@OskarDamkjaer OskarDamkjaer changed the title SSO for browser Preview of SSO for browser Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jharris4 jharris4 jharris4 approved these changes

Assignees
No one assigned
Labels
changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OskarDamkjaer @jharris4