Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include pathname in redirect to fix SSO #1528

Merged
merged 1 commit into from
Sep 15, 2021
Merged

Include pathname in redirect to fix SSO #1528

merged 1 commit into from
Sep 15, 2021

Conversation

OskarDamkjaer
Copy link
Contributor

The SSO-redirect accidentally removes the pathname from the URL as well, breaking SSO on aura. This fixes it, tested locally with browser hosted on /browser

oskarhane
oskarhane approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@oskarhane oskarhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - though we should think about adding tests in the shared lib later. 🧔

@OskarDamkjaer OskarDamkjaer merged commit 077bb55 into neo4j:master Sep 15, 2021
@OskarDamkjaer OskarDamkjaer changed the title Include pathname in redirect Include pathname in redirect to fix SSO Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oskarhane oskarhane oskarhane approved these changes

@jharris4 jharris4 Awaiting requested review from jharris4

Assignees
No one assigned
Labels
changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OskarDamkjaer @oskarhane