Add support for handling multiple commands from browser.post_connect_cmd #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are assumed to be splitted by semicolon.
pe4cey
reviewed
May 23, 2017
| { str: ';:play cypher;', expect: [':play cypher'] }, | ||
| { str: ':play cypher; :param x: 1', expect: [':play cypher', ':param x: 1'] }, | ||
| { str: 'RETURN 1; RETURN 3; :play start', expect: ['RETURN 1', 'RETURN 3', ':play start'] } | ||
| ] |
There was a problem hiding this comment.
Splitting on ; means that if you have a cypher query containing ; then that will also split.
Test case: { str: 'MATCH (n: {foo: "bar;"}) RETURN n', expect: ['MATCH (n: {foo: "bar;"}) RETURN n'] }
|
Added basic semicolons-within-quotes detection @pe4cey. |
oskarhane
force-pushed
the
3.0-multi-post_connect_cmd
branch
from
396a74c to
4269c9d
Compare
oskarhane
force-pushed
the
3.0-multi-post_connect_cmd
branch
from
4269c9d to
42067f3
Compare
dhimmel
added a commit
to hetio/hetionet
that referenced
this pull request
Sep 18, 2017
dhimmel
added a commit
to hetio/hetionet
that referenced
this pull request
Nov 7, 2018
|
breaking commands on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are assumed to be separated by semicolon.
Example:
browser.post_connect_cmd=play welcome; style http://server.com/style.grass; config useBoltRouting: trueRemember to leave out the command character
:from commands in the server config.Also, execution of Cypher is not possible.
I had to refactor some in the tests files to have the tests running as expected. There seems to be a bug in either
configureMockStoreorcreateEpicMiddleware.