Add support for setting browser :config with objects
#594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ability to accept setting browser configs with a JSON string, like: `:config {"maxFrames":50, "theme": "outline"}`
oskarhane
force-pushed
the
3.0-config-json-string
branch
from
df11599 to
82549a1
Compare
oskarhane
changed the title
:config with JSON object string:config with objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to accept setting browser configs with a JSON string, like:
:config {"maxFrames":50, "theme": "outline"}or the more related format like::config {maxFrames: 50, theme: "outline"}When setting config with an JSON object string, the current config is being replaced (merged with the default values) not updated as the case when setting single config values.
Helpful hints are displayed below the editor to enlighten users if something goes wrong.