Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remap query plan arguments to the root object #655

Merged
merged 1 commit into from
Oct 9, 2017

Conversation

pe4cey
Copy link
Contributor

@pe4cey pe4cey commented Oct 5, 2017

  • Re-enable skipped boltMapping tests

Before:
all-node-scan-old

After:
all-nodes-scan-new

Changelog: In query plan: show the label that has been scanned

@oskarhane
Copy link
Member

Something strange happens with the total dbHits.
On 3.0: Cypher version: CYPHER 3.3, planner: COST, runtime: INTERPRETED. 1443 total db hits in 2 ms.
On this PR: Cypher version: CYPHER 3.3, planner: COST, runtime: INTERPRETED. 00025313200506677172 total db hits in 4 ms.

Query (with movie dataset):

PROFILE MATCH (n) WHERE EXISTS(n.name) RETURN DISTINCT "node" as entity, n.name AS name LIMIT 25 UNION ALL MATCH ()-[r]-() WHERE EXISTS(r.name) RETURN DISTINCT "relationship" AS entity, r.name AS name LIMIT 25

- Run skipped boltMapping tests
@pe4cey pe4cey force-pushed the remap-arguments-to-root branch from 8130a43 to 18e7a5e Compare October 6, 2017 18:00
@pe4cey
Copy link
Contributor Author

pe4cey commented Oct 6, 2017

@oskarhane updated

@oskarhane oskarhane merged commit d5d91c1 into neo4j:3.0 Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants