-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate with desktop API #664
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do dont update old frames with new connection data.
oskarhane
force-pushed
the
3.0-desktop-integration
branch
2 times, most recently
from
October 13, 2017 14:44
48db676
to
3a96a92
Compare
oskarhane
force-pushed
the
3.0-desktop-integration
branch
from
October 16, 2017 06:36
3a96a92
to
f360b9e
Compare
oskarhane
force-pushed
the
3.0-desktop-integration
branch
from
October 16, 2017 08:17
5ab69c9
to
3daab6f
Compare
Blocking this from merging now since we need to update it to adhere to the new api context format |
Updated to use new API version |
Act on GRAPH_ACTIVE and GRAPH_INACTIVE rather than DATABASE_STARTED and DATABASE_STOPPED
oskarhane
force-pushed
the
3.0-desktop-integration
branch
from
October 17, 2017 06:53
270d800
to
476c344
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New component
We added the
DesktopIntegration
component which reads initial context and sets up a listener for events that the desktop att emits.To react on events happening you attach props to the component in the form of
EVENT_NAME
->onEventName
.Example on react on
DATABASE_STARTED
->To get the initial context on app load, you attach the
Features
In web env, no changes are expected.
In desktop env, this should be the behaviour:
When browser is opened when a graph already is running:
:server connect
and the host should be what the active graph has.When browser is open and connected and graph is shut down:
When browser is open but not connected to a graph and a graph starts:
:server switch success
frame and inform about the connection switch.:server switch fail
frame and inform about the failure:server connect
link to manually enter creds.Worth mentions
mount
function intestUtils.js
we can now pass a second param with props to get to test thecomponentDidMount
lifecycle method.appDuck.js
there are now selectors to check what environment the browser lives in. Useful for code branching.DesktopIntegration/helpers.js
should be used by outside components to extract and compare data coming from the desktop api.