Persist grass to neo4j sync #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskarhane
reviewed
Nov 24, 2017
| this.props.sendActionToDispatch({ type: 'grass/SYNC_GRASS' })} | ||
| > | ||
| Sync grass | ||
| </button> |
There was a problem hiding this comment.
Why do we have this button here? Sync happens automatically, right?
|
PR updated |
|
There seems to be an issue where style changes are spammed to the sync service, hogging down the Browser completely. Also, the data seems a bit wrong:
This is going from no |
myzero1
pushed a commit
to myzero1/neo4j-browser
that referenced
this pull request
May 17, 2019
Persist grass to neo4j sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a known regression where users' grass files are no longer syncs with the neo4j browser sync service.
changelog: Sync styling with Browser sync