-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multi-statement execution #722
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't merge, will add more tests |
oskarhane
force-pushed
the
multi-statements
branch
2 times, most recently
from
March 20, 2018 09:49
ecb8877
to
df5d2c6
Compare
More tests added |
oskarhane
force-pushed
the
multi-statements
branch
from
March 22, 2018 14:54
df5d2c6
to
01da817
Compare
oskarhane
force-pushed
the
multi-statements
branch
from
April 26, 2018 12:35
dcf99ba
to
9a4d3a5
Compare
oskarhane
force-pushed
the
multi-statements
branch
from
June 11, 2018 07:30
9a4d3a5
to
a32613d
Compare
… by taking the raw value in editor and parse it before executing it
The `onParsed` is already debounced
Cleanup error files and make command error frame pretty.
Add tests for multi statement + unknown command error frame.
Groups requests in it’s `statements` property
And ignore client side commands
oskarhane
force-pushed
the
multi-statements
branch
from
June 28, 2018 07:01
60f70bd
to
09c3630
Compare
Put it on the epic level so all commands get extracted and handled as editor commands = support from everywhere as long as `executeCommand` is used.
- Get all statements from `parse()`
myzero1
pushed a commit
to myzero1/neo4j-browser
that referenced
this pull request
May 17, 2019
Add support for multi-statement execution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Neo4j Browser will separate all statements and execute them one-by-one and break on first error and present them in a single frame with expandable view to see information about the result, but not the result itself.
Requirements
:
) will be ignored.:param
since they're related to cypher queries and can be seen as a natural part of a multi statement storyInformation
Changes that made this possible:
cypher-codemirror
which now exports aparse
commandFor Reviewers
Command to try (all of northwind guide):