Switch to React 16.4 #784
Merged
Switch to React 16.4 #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problems with this.base
And unmute muted tests and remove failing ones
Replace formKeyHandler and build a more reactish solution
Editor wasn’t populated
|
@akollegger Can you check if https://github.com/oskarhane/neo4j-browser/blob/ded70fb2dacd8a4b19410dae384059a01ae6c154/NOTICE.txt looks ok? |
myzero1
pushed a commit
to myzero1/neo4j-browser
that referenced
this pull request
May 17, 2019
Switch to React 16.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main work was to make the JSX pragma import explicit.
And fix missing
keyprops.And some ref differences for viz, scrolling stream to top, enter in forms to get to next field etc.
Ported most of the component tests to react-testing-library, and it's really easy to use and tests get very clean and you're not lured into testing implementation details.
I've added a bunch of extra e2e tests as well to make sure none of our commands breaks the app.
Please try to break it.
It can be found on https://dist-xjxjivnrky.now.sh. Just connect to your local db and hammer it.