Add pagecache hits and misses to plan output #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pe4cey
reviewed
Aug 21, 2018
| @@ -179,6 +179,19 @@ neo.queryPlan = function(element) { | |||
| details.push({ className: 'padding' }) | |||
| } | |||
|
|
|||
| if (operator.PageCacheHits || operator.PageCacheMisses) { | |||
There was a problem hiding this comment.
Aren't PageCacheHits and PageCacheMisses (if present) always come together in the result?
If one is present but the other isn't; how does formatNumber bellow handle undefined?
There was a problem hiding this comment.
Yes, they come together.
Those are also zero checks since the result sends PageCacheHits: 0, PageCacheMisses: 0 and in that case we don't want to show them at all.
But if one of them aren't 0, we want to show them.
@pe4cey.
| details.push({ | ||
| className: 'pagecache-hits', | ||
| key: 'pagecache hits', | ||
| value: formatNumber(operator.PageCacheHits) |
myzero1
pushed a commit
to myzero1/neo4j-browser
that referenced
this pull request
May 17, 2019
Add pagecache hits and misses to plan output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show page cache stats right next to hits / estimated row stats.
I also added a E2E test for it.
(Sorry for the formatting changes, I guess prettier got updated.)