Fix :server switch bug + E2E tests for within a Neo4j Desktop env
#822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskarhane
force-pushed
the
desktop-api-e2e
branch
4 times, most recently
from
6b41194 to
c13ab40
Compare
oskarhane
force-pushed
the
desktop-api-e2e
branch
4 times, most recently
from
9119947 to
fd528f9
Compare
oskarhane
force-pushed
the
desktop-api-e2e
branch
from
4191e79 to
fbefd5d
Compare
Also: test connection when provided by desktop api. Inject fake `window.neo4jDesktopApi` in a testfile and test auto connection + connection switch Added e2e test config bolt-url to README
oskarhane
force-pushed
the
desktop-api-e2e
branch
from
fbefd5d to
54b70e6
Compare
myzero1
pushed a commit
to myzero1/neo4j-browser
that referenced
this pull request
May 17, 2019
Fix `:server switch` bug + E2E tests for within a Neo4j Desktop env
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring back mistakenly deleted code 😳
Inject fake
window.neo4jDesktopApiin a testfile and test auto connection + connection switchI also refactored the E2E tests to not have a global
beforehook, but to have one in each file instead to be able to have a different one in the new tests file.A new E2E test variable is also added,
bolt-url, to be able to run tests against other bolt servers thanlocalhost:7687.changelog: Fix
:server switchbug in Neo4j Desktop environment