Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update neo4j-driver to 1.7 and send transaction metadata with Cypher queries #848

Merged
merged 7 commits into from
Oct 19, 2018

Conversation

oskarhane
Copy link
Member

This is not for all places yet, this is for the recurring background queries + user executed queries.
If we pass metadata along to a pre neo4j 3.5.0 server, it returns a error message, that’s why we need to figure out the server version before start sending.

Log entries look like:

2018-10-18 10:36:24.790+0000 INFO  6 ms: bolt-session	bolt	neo4j	neo4j-javascript/1.7.0-rc2		client/127.0.0.1:53154	server/127.0.0.1:7687>	neo4j - CALL dbms.queryJmx("org.neo4j:*") - {} - {type: 'NEO4J_BROWSER_BACKGROUND_QUERY', application: 'NEO4J_BROWSER_V3.2.9', query_number: 43.0}
2018-10-18 10:25:55.712+0000 INFO  56 ms: bolt-session	bolt	neo4j	neo4j-javascript/1.7.0-rc2		client/127.0.0.1:50157	server/127.0.0.1:7687>	neo4j - MATCH (n) RETURN n LIMIT 25 - {} - {type: 'NEO4J_BROWSER_USER_QUERY', application: 'NEO4J_BROWSER_V3.2.9', query_number: 1.0}

:queries looks like:

oskarhane-mbpt 2018-10-18 at 12 02 12

This is not for all places yet, this is for the recurring background queries + user executed queries.
If we pass metadata along to a pre neo4j 3.5.0 server, it returns a error message, that’s why we need to figure out the server version before start sending.
@oskarhane oskarhane merged commit c9c6ad8 into neo4j:master Oct 19, 2018
@oskarhane oskarhane deleted the driver-1.7 branch October 19, 2018 12:31
myzero1 pushed a commit to myzero1/neo4j-browser that referenced this pull request May 17, 2019
Update neo4j-driver to 1.7 and send transaction metadata with Cypher queries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant