Show query termination message when closing frame that has an active query #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Potentially also fix bug where queries wasn’t canceled properly
oskarhane
force-pushed
the
show-tx-cancel
branch
from
1a90b78 to
166d79c
Compare
oskarhane
force-pushed
the
show-tx-cancel
branch
from
0c86b7b to
d93b444
Compare
oskarhane
changed the title
myzero1
pushed a commit
to myzero1/neo4j-browser
that referenced
this pull request
May 17, 2019
Show query termination message when closing frame that has an active query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be more explicit to users what's going on.
This does also fix a bug where closing a frame didn't always terminate the query properly.
New behavior: