Export query result records as JSON #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huboneo
commented
Aug 15, 2019
| } from 'browser/modules/Stream/CypherFrame/helpers' | ||
| import { csvFormat } from 'services/bolt/cypherTypesFormatting' | ||
| import arrayHasItems from 'shared/utils/array-has-items' | ||
|
|
||
| const JSON_EXPORT_INDENT = 2 |
There was a problem hiding this comment.
@oskarhane any suggestions for where to put this?
There was a problem hiding this comment.
No need to extract this at all imo.
| line-height: 30px; | ||
| padding: 5px 0 5px 0; | ||
| padding: 5px 10px; |
There was a problem hiding this comment.
Had to do this to fix dropdown
There was a problem hiding this comment.
moved this to DropdownItem to fix appearance
huboneo
commented
Aug 15, 2019
| case neo4j.types.LocalTime: | ||
| case neo4j.types.Time: | ||
| case neo4j.types.Point: | ||
| case neo4j.types.Integer: // not exposed in typings but still there |
There was a problem hiding this comment.
Could be that I should call toInt() for Integers?
- CSS fix - Export int as Number - Export Point as GeoJSON - Reorder and cleanup
huboneo
force-pushed
the
feature-export-data-json
branch
from
ab3c3d7 to
8280de0
Compare
oskarhane
approved these changes
Aug 16, 2019
| } from 'browser/modules/Stream/CypherFrame/helpers' | ||
| import { csvFormat } from 'services/bolt/cypherTypesFormatting' | ||
| import arrayHasItems from 'shared/utils/array-has-items' | ||
|
|
||
| const JSON_EXPORT_INDENT = 2 |
There was a problem hiding this comment.
No need to extract this at all imo.
| @@ -726,4 +727,510 @@ describe('helpers', () => { | |||
| ]) | |||
| }) | |||
| }) | |||
|
|
|||
| describe('recordToJSONMapper', () => { | |||
oskarhane
reviewed
Aug 19, 2019
| } | ||
|
|
||
| // could be a Node or Relationship | ||
| const type = lowerCase(get(values, 'constructor.name', '')) |
There was a problem hiding this comment.
From discussion: call this elementType
oskarhane
reviewed
Aug 19, 2019
| const type = lowerCase(get(values, 'constructor.name', '')) | ||
|
|
||
| if (includes(['relationship', 'node'], type)) { | ||
| const labels = |
There was a problem hiding this comment.
From discussion: Call this type for relationships and keep labels for nodes.
|
@oskarhane updated the PR as per your comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables users to export result records as JSON, trying to mimic APOC output as much as possible.
STR
MATCH p = (:Person)-[r]-(:Movie) RETURN pScreenshots
Sample output
See unit tests